[kernel] r9075 - in dists/etch-security/linux-2.6/debian: . patches/bugfix patches/series

[Dann Frazier]

Author: dannf
Date: Fri Jul  6 04:37:13 2007
New Revision: 9075

Log:
* bugfix/pppoe-socket-release-mem-leak.patch
  [SECURITY] fix unpriveleged memory leak when a PPPoE socket is released
  after connect but before PPPIOCGCHAN ioctl is called upon it
  See CVE-2007-2525

Added:
   dists/etch-security/linux-2.6/debian/patches/bugfix/pppoe-socket-release-mem-leak.patch
Modified:
   dists/etch-security/linux-2.6/debian/changelog
   dists/etch-security/linux-2.6/debian/patches/series/13etch1

Modified: dists/etch-security/linux-2.6/debian/changelog
==============================================================================
--- dists/etch-security/linux-2.6/debian/changelog	(original)
+++ dists/etch-security/linux-2.6/debian/changelog	Fri Jul  6 04:37:13 2007
@@ -9,8 +9,12 @@
   * bugfix/usblcd-limit-memory-consumption.patch
     [SECURITY] limit memory consumption during write in the usblcd driver
     See CVE-2007-3513
+  * bugfix/pppoe-socket-release-mem-leak.patch
+    [SECURITY] fix unpriveleged memory leak when a PPPoE socket is released
+    after connect but before PPPIOCGCHAN ioctl is called upon it
+    See CVE-2007-2525
 
- -- dann frazier <dannf at debian.org>  Wed, 04 Jul 2007 08:57:36 -0600
+ -- dann frazier <dannf at debian.org>  Thu, 05 Jul 2007 22:35:14 -0600
 
 linux-2.6 (2.6.18.dfsg.1-13) stable; urgency=high
 

Added: dists/etch-security/linux-2.6/debian/patches/bugfix/pppoe-socket-release-mem-leak.patch
==============================================================================
--- (empty file)
+++ dists/etch-security/linux-2.6/debian/patches/bugfix/pppoe-socket-release-mem-leak.patch	Fri Jul  6 04:37:13 2007
@@ -0,0 +1,42 @@
+From: Florian Zumbiehl <florz at florz.de>
+Date: Fri, 20 Apr 2007 23:58:14 +0000 (-0700)
+Subject: [PPPOE]: memory leak when socket is release()d before PPPIOCGCHAN has been called ...
+X-Git-Tag: v2.6.22-rc1~1128^2~92
+X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=202a03acf9994076055df40ae093a5c5474ad0bd
+
+[PPPOE]: memory leak when socket is release()d before PPPIOCGCHAN has been called on it
+
+below you find a patch that fixes a memory leak when a PPPoE socket is
+release()d after it has been connect()ed, but before the PPPIOCGCHAN ioctl
+ever has been called on it.
+
+This is somewhat of a security problem, too, since PPPoE sockets can be
+created by any user, so any user can easily allocate all the machine's
+RAM to non-swappable address space and thus DoS the system.
+
+Is there any specific reason for PPPoE sockets being available to any
+unprivileged process, BTW? After all, you need a packet socket for the
+discovery stage anyway, so it's unlikely that any unprivileged process
+will ever need to create a PPPoE socket, no? Allocating all session IDs
+for a known AC is a kind of DoS, too, after all - with Juniper ERXes,
+this is really easy, actually, since they don't ever assign session ids
+above 8000 ...
+
+Signed-off-by: Florian Zumbiehl <florz at florz.de>
+Acked-by: Michal Ostrowski <mostrows at earthlink.net>
+Signed-off-by: David S. Miller <davem at davemloft.net>
+---
+
+diff --git a/drivers/net/pppox.c b/drivers/net/pppox.c
+index 9315046..3f8115d 100644
+--- a/drivers/net/pppox.c
++++ b/drivers/net/pppox.c
+@@ -58,7 +58,7 @@ void pppox_unbind_sock(struct sock *sk)
+ {
+ 	/* Clear connection to ppp device, if attached. */
+ 
+-	if (sk->sk_state & (PPPOX_BOUND | PPPOX_ZOMBIE)) {
++	if (sk->sk_state & (PPPOX_BOUND | PPPOX_CONNECTED | PPPOX_ZOMBIE)) {
+ 		ppp_unregister_channel(&pppox_sk(sk)->chan);
+ 		sk->sk_state = PPPOX_DEAD;
+ 	}

Modified: dists/etch-security/linux-2.6/debian/patches/series/13etch1
==============================================================================
--- dists/etch-security/linux-2.6/debian/patches/series/13etch1	(original)
+++ dists/etch-security/linux-2.6/debian/patches/series/13etch1	Fri Jul  6 04:37:13 2007
@@ -2,3 +2,4 @@
 + bugfix/fat-move-ioctl-compat-code.patch
 + bugfix/fat-fix-compat-ioctls.patch
 + bugfix/usblcd-limit-memory-consumption.patch
++ bugfix/pppoe-socket-release-mem-leak.patch