[kernel] r13983 - in dists/lenny/linux-2.6/debian: . patches/bugfix/all patches/series

[Moritz Muehlenhoff]

Author: jmm
Date: Mon Jul 20 23:00:51 2009
New Revision: 13983

Log:
* eeepc: Fix oops when changing backlight brightness during init
    (Closes: #513406)

Added:
   dists/lenny/linux-2.6/debian/patches/bugfix/all/eeepc-fix-oops-when-changing-backlight-brightness-during-init.patch
Modified:
   dists/lenny/linux-2.6/debian/changelog
   dists/lenny/linux-2.6/debian/patches/series/18

Modified: dists/lenny/linux-2.6/debian/changelog
==============================================================================
--- dists/lenny/linux-2.6/debian/changelog	Mon Jul 20 22:47:24 2009	(r13982)
+++ dists/lenny/linux-2.6/debian/changelog	Mon Jul 20 23:00:51 2009	(r13983)
@@ -20,6 +20,8 @@
   * fbdev/atyfb: Fix display corruption on some PowerMacs & PowerBooks
     (Closes: #420582)
   * ALSA: hda_intel: enable snoop for NVidia HDA controller (Closes: #521192)
+  * eeepc: Fix oops when changing backlight brightness during init
+    (Closes: #513406)
 
   [ dann frazier ]
   * sata_nv: avoid link reset on controllers where it's broken

Added: dists/lenny/linux-2.6/debian/patches/bugfix/all/eeepc-fix-oops-when-changing-backlight-brightness-during-init.patch
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ dists/lenny/linux-2.6/debian/patches/bugfix/all/eeepc-fix-oops-when-changing-backlight-brightness-during-init.patch	Mon Jul 20 23:00:51 2009	(r13983)
@@ -0,0 +1,72 @@
+From: Darren Salt <linux at youmustbejoking.demon.co.uk>
+Date: Sat, 7 Feb 2009 06:02:07 +0000 (-0500)
+Subject: eeepc-laptop: fix oops when changing backlight brightness during eeepc-laptop init
+X-Git-Tag: v2.6.29-rc4~7^2^6~1
+X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=7695fb04aca62e2d8a7ca6ede50f6211e1d71e53;hp=386e4a8358239f90275e1f93d5ad11cdc93c6453
+
+eeepc-laptop: fix oops when changing backlight brightness during eeepc-laptop init
+
+I got the following oops while changing the backlight brightness during
+startup.  When it happens, it prevents use of the hotkeys, Fn-Fx, and the
+lid button.
+
+It's a clear use-before-init, as I verified by testing with an
+appropriately-placed "else printk".
+
+BUG: unable to handle kernel NULL pointer dereference at 00000000
+*pde = 00000000
+Oops: 0002 [#1] PREEMPT SMP
+Pid: 160, comm: kacpi_notify Not tainted (2.6.28.1-eee901 #4) 901
+EIP: 0060:[<c0264e68>]  [<c0264e68>] eeepc_hotk_notify+26/da
+EFLAGS: 00010246 CPU: 1
+Using defaults from ksymoops -t elf32-i386 -a i386
+EAX: 00000009 EBX: 00000000 ECX: 00000009 EDX: f70dbf64
+ESI: 00000029 EDI: f7335188 EBP: c02112c9 ESP: f70dbf80
+ DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
+ f70731e0 f73acd50 c02164ac f7335180 f70aa040 c02112e6 f733518c c012b62f
+ f70aa044 f70aa040 c012bdba f70aa04c 00000000 c012be6e 00000000 f70bdf80
+ c012e198 f70dbfc4 f70dbfc4 f70aa040 c012bdba 00000000 c012e0c9 c012e091
+Call Trace:
+ [<c02164ac>] ? acpi_ev_notify_dispatch+4c/55
+ [<c02112e6>] ? acpi_os_execute_deferred+1d/25
+ [<c012b62f>] ? run_workqueue+71/f1
+ [<c012bdba>] ? worker_thread+0/bf
+ [<c012be6e>] ? worker_thread+b4/bf
+ [<c012e198>] ? autoremove_wake_function+0/2b
+ [<c012bdba>] ? worker_thread+0/bf
+ [<c012e0c9>] ? kthread+38/5f
+ [<c012e091>] ? kthread+0/5f
+ [<c0103abf>] ? kernel_thread_helper+7/10
+Code: 00 00 00 00 c3 83 3d 60 5c 50 c0 00 56 89 d6 53 0f 84 c4 00 00 00 8d 42
+e0 83 f8 0f 77 0f 8b 1d 68 5c 50 c0 89 d8 e8 a9 fa ff ff <89> 03 8b 1d 60 5c
+50 c0 89 f2 83 e2 7f 0f b7 4c 53 10 8d 41 01
+
+[With modifications for 2.6.26]
+
+Signed-off-by: Darren Salt <linux at youmustbejoking.demon.co.uk>
+Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
+Signed-off-by: Len Brown <len.brown at intel.com>
+---
+
+diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
+index 9d93cb9..8fb983f 100644
+--- a/drivers/platform/x86/eeepc-laptop.c
++++ b/drivers/misc/eeepc-laptop.c
+@@ -510,7 +510,8 @@ static int eeepc_hotk_check(void)
+ static void notify_brn(void)
+ {
+ 	struct backlight_device *bd = eeepc_backlight_device;
+-	bd->props.brightness = read_brightness(bd);
++	if (bd)
++		bd->props.brightness = read_brightness(bd);
+ }
+ 
+ static void eeepc_hotk_notify(acpi_handle handle, u32 event, void *data)
+
+
+
+
+
+
+
+

Modified: dists/lenny/linux-2.6/debian/patches/series/18
==============================================================================
--- dists/lenny/linux-2.6/debian/patches/series/18	Mon Jul 20 22:47:24 2009	(r13982)
+++ dists/lenny/linux-2.6/debian/patches/series/18	Mon Jul 20 23:00:51 2009	(r13983)
@@ -8,4 +8,5 @@
 + bugfix/all/drivers-ata-sata_nv-broken-hardreset.patch
 + bugfix/all/libata-make-sure-port-is-thawed-when-skipping-reset.patch
 + bugfix/all/add-fno-delete-null-pointer-checks-to-CFLAGS.patch
-+ bugfix/all/sound-enable-snoop-for-nvidia-hda.patch
\ No newline at end of file
++ bugfix/all/sound-enable-snoop-for-nvidia-hda.patch
++ bugfix/all/eeepc-fix-oops-when-changing-backlight-brightness-during-init.patch