[kernel] r16003 - in dists/trunk/tgt/debian: . patches

[Ben Hutchings]

Author: benh
Date: Wed Jul 21 01:05:57 2010
New Revision: 16003

Log:
Fix bashism in tgt-admin, thanks to Chris Cheney (Closes: #589716)

Added:
   dists/trunk/tgt/debian/patches/fix-tgt-admin-bashism
Modified:
   dists/trunk/tgt/debian/changelog
   dists/trunk/tgt/debian/patches/series

Modified: dists/trunk/tgt/debian/changelog
==============================================================================
--- dists/trunk/tgt/debian/changelog	Wed Jul 21 01:01:03 2010	(r16002)
+++ dists/trunk/tgt/debian/changelog	Wed Jul 21 01:05:57 2010	(r16003)
@@ -1,3 +1,9 @@
+tgt (1:1.0.4-2) UNRELEASED; urgency=low
+
+  * Fix bashism in tgt-admin, thanks to Chris Cheney (Closes: #589716)
+
+ -- Ben Hutchings <ben at decadent.org.uk>  Wed, 21 Jul 2010 02:04:46 +0100
+
 tgt (1:1.0.4-1) unstable; urgency=low
 
   * New upstream release.

Added: dists/trunk/tgt/debian/patches/fix-tgt-admin-bashism
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ dists/trunk/tgt/debian/patches/fix-tgt-admin-bashism	Wed Jul 21 01:05:57 2010	(r16003)
@@ -0,0 +1,32 @@
+From: Chris Cheney <ccheney at debian.org>
+Date: Tue, 20 Jul 2010 04:44:14 -0500
+Subject: Bug#589716: tgtd target will not start unless it's configured with
+ "allow-in-use yes"
+
+Package: tgt
+Version: 1:1.0.4-1
+Severity: important
+
+"tgt-admin will not start a target unless we specify the "allow-in-use
+yes" directive in the target declaration. It complains that the device
+is in use, although I am positive it is not. Specifying "allow-in-use
+yes" is not recommended, and doing so is not really satisfactory."
+
+This appears to have been caused by a faulty system call which appears
+to be corrected by the below patch.
+
+Thanks,
+
+Chris
+
+--- tgt-1.0.4/scripts/tgt-admin 2010-04-29 01:16:34.000000000 -0500
++++ tgt-1.0.4/scripts/tgt-admin 2010-07-20 04:32:55.603760363 -0500
+@@ -1166,7 +1166,7 @@
+ 	# Check if userspace uses this device
+ 	my $lsof_check = check_exe("lsof");
+ 	if ($lsof_check ne 1) {
+-		system("lsof $backing_store &>/dev/null");
++		system("lsof $backing_store > /dev/null 2>&1");
+ 		my $exit_value  = $? >> 8;
+ 		if ($exit_value eq 0) {
+ 			execute("# Device $backing_store is used (already tgtd target?).");

Modified: dists/trunk/tgt/debian/patches/series
==============================================================================
--- dists/trunk/tgt/debian/patches/series	Wed Jul 21 01:01:03 2010	(r16002)
+++ dists/trunk/tgt/debian/patches/series	Wed Jul 21 01:05:57 2010	(r16003)
@@ -1,2 +1,3 @@
 make-tgt-setup-lun-executable
 conf-makefile
+fix-tgt-admin-bashism