[kernel] r16545 - in dists/lenny-security/linux-2.6/debian: . patches/bugfix/all patches/series

[Dann Frazier]

Author: dannf
Date: Thu Nov 11 03:39:43 2010
New Revision: 16545

Log:
video/sis: prevent reading uninitialized stack memory (CVE-2010-4078)

Added:
   dists/lenny-security/linux-2.6/debian/patches/bugfix/all/video-sis-prevent-reading-uninitialized-stack-memory.patch
Modified:
   dists/lenny-security/linux-2.6/debian/changelog
   dists/lenny-security/linux-2.6/debian/patches/series/25lenny2

Modified: dists/lenny-security/linux-2.6/debian/changelog
==============================================================================
--- dists/lenny-security/linux-2.6/debian/changelog	Thu Nov 11 02:00:35 2010	(r16544)
+++ dists/lenny-security/linux-2.6/debian/changelog	Thu Nov 11 03:39:43 2010	(r16545)
@@ -16,6 +16,7 @@
   * ALSA: rme9652: prevent reading uninitialized stack memory
     (CVE-2010-4080, CVE-2010-4081)
   * V4L/DVB: ivtvfb: prevent reading uninitialized stack memory (CVE-2010-4079)
+  * video/sis: prevent reading uninitialized stack memory (CVE-2010-4078)
 
  -- dann frazier <dannf at debian.org>  Thu, 30 Sep 2010 21:42:24 -0600
 

Added: dists/lenny-security/linux-2.6/debian/patches/bugfix/all/video-sis-prevent-reading-uninitialized-stack-memory.patch
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ dists/lenny-security/linux-2.6/debian/patches/bugfix/all/video-sis-prevent-reading-uninitialized-stack-memory.patch	Thu Nov 11 03:39:43 2010	(r16545)
@@ -0,0 +1,31 @@
+commit fd02db9de73faebc51240619c7c7f99bee9f65c7
+Author: Dan Rosenberg <drosenberg at vsecurity.com>
+Date:   Wed Sep 22 13:05:09 2010 -0700
+
+    drivers/video/sis/sis_main.c: prevent reading uninitialized stack memory
+    
+    The FBIOGET_VBLANK device ioctl allows unprivileged users to read 16 bytes
+    of uninitialized stack memory, because the "reserved" member of the
+    fb_vblank struct declared on the stack is not altered or zeroed before
+    being copied back to the user.  This patch takes care of it.
+    
+    Signed-off-by: Dan Rosenberg <dan.j.rosenberg at gmail.com>
+    Cc: Thomas Winischhofer <thomas at winischhofer.net>
+    Cc: <stable at kernel.org>
+    Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
+    Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
+
+diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
+index 559bf17..b52f8e4 100644
+--- a/drivers/video/sis/sis_main.c
++++ b/drivers/video/sis/sis_main.c
+@@ -1701,6 +1701,9 @@ static int	sisfb_ioctl(struct fb_info *info, unsigned int cmd,
+ 		break;
+ 
+ 	   case FBIOGET_VBLANK:
++
++		memset(&sisvbblank, 0, sizeof(struct fb_vblank));
++
+ 		sisvbblank.count = 0;
+ 		sisvbblank.flags = sisfb_setupvbblankflags(ivideo, &sisvbblank.vcount, &sisvbblank.hcount);
+ 

Modified: dists/lenny-security/linux-2.6/debian/patches/series/25lenny2
==============================================================================
--- dists/lenny-security/linux-2.6/debian/patches/series/25lenny2	Thu Nov 11 02:00:35 2010	(r16544)
+++ dists/lenny-security/linux-2.6/debian/patches/series/25lenny2	Thu Nov 11 03:39:43 2010	(r16545)
@@ -14,3 +14,4 @@
 + bugfix/all/sys_semctl-fix-kernel-stack-leakage.patch
 + bugfix/all/rme9652-prevent-reading-uninitialized-stack-memory.patch
 + bugfix/all/ivtvfb-prevent-reading-uninitialized-stack-memory.patch
++ bugfix/all/video-sis-prevent-reading-uninitialized-stack-memory.patch