[kernel] r18437 - in dists/sid/linux-2.6/debian: . patches/bugfix/all patches/series

Ben Hutchings benh at alioth.debian.org
Fri Dec 30 11:03:37 UTC 2011


Author: benh
Date: Fri Dec 30 11:03:36 2011
New Revision: 18437

Log:
l2tp: ensure sk->dst is still valid (Closes: #652503)

Added:
   dists/sid/linux-2.6/debian/patches/bugfix/all/l2tp-ensure-sk-dst-is-still-valid.patch
Modified:
   dists/sid/linux-2.6/debian/changelog
   dists/sid/linux-2.6/debian/patches/series/base

Modified: dists/sid/linux-2.6/debian/changelog
==============================================================================
--- dists/sid/linux-2.6/debian/changelog	Thu Dec 29 23:17:57 2011	(r18436)
+++ dists/sid/linux-2.6/debian/changelog	Fri Dec 30 11:03:36 2011	(r18437)
@@ -9,6 +9,7 @@
     - bridge: provide a mtu() method for fake_dst_ops
     - net: introduce DST_NOPEER dst flag
   * rtc: Fix alarm rollover when day or month is out-of-range (Closes: #646429)
+  * l2tp: ensure sk->dst is still valid (Closes: #652503)
 
   [ Jonathan Nieder ]
   * prerm: Print an error message when aborting removal of the running

Added: dists/sid/linux-2.6/debian/patches/bugfix/all/l2tp-ensure-sk-dst-is-still-valid.patch
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ dists/sid/linux-2.6/debian/patches/bugfix/all/l2tp-ensure-sk-dst-is-still-valid.patch	Fri Dec 30 11:03:36 2011	(r18437)
@@ -0,0 +1,38 @@
+From: Florian Westphal <fw at strlen.de>
+Date: Fri, 25 Nov 2011 06:47:16 +0000
+Subject: [PATCH] l2tp: ensure sk->dst is still valid
+
+commit 71b1391a41289735676be02e35239e5aa9fe6ba6 upstream.
+
+When using l2tp over ipsec, the tunnel will hang when rekeying
+occurs. Reason is that the transformer bundle attached to the dst entry
+is now in STATE_DEAD and thus xfrm_output_one() drops all packets
+(XfrmOutStateExpired increases).
+
+Fix this by calling __sk_dst_check (which drops the stale dst
+if xfrm dst->check callback finds that the bundle is no longer valid).
+
+Cc: James Chapman <jchapman at katalix.com>
+Signed-off-by: Florian Westphal <fw at strlen.de>
+Acked-by: Eric Dumazet <eric.dumazet at gmail.com>
+Signed-off-by: David S. Miller <davem at davemloft.net>
+---
+ net/l2tp/l2tp_core.c |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
+index cf0f308..89ff8c6 100644
+--- a/net/l2tp/l2tp_core.c
++++ b/net/l2tp/l2tp_core.c
+@@ -1072,7 +1072,7 @@ int l2tp_xmit_skb(struct l2tp_session *session, struct sk_buff *skb, int hdr_len
+ 
+ 	/* Get routing info from the tunnel socket */
+ 	skb_dst_drop(skb);
+-	skb_dst_set(skb, dst_clone(__sk_dst_get(sk)));
++	skb_dst_set(skb, dst_clone(__sk_dst_check(sk, 0)));
+ 
+ 	inet = inet_sk(sk);
+ 	fl = &inet->cork.fl;
+-- 
+1.7.7.3
+

Modified: dists/sid/linux-2.6/debian/patches/series/base
==============================================================================
--- dists/sid/linux-2.6/debian/patches/series/base	Thu Dec 29 23:17:57 2011	(r18436)
+++ dists/sid/linux-2.6/debian/patches/series/base	Fri Dec 30 11:03:36 2011	(r18437)
@@ -92,3 +92,4 @@
 + bugfix/all/bridge-provide-a-mtu-method-for-fake_dst_ops.patch
 + bugfix/all/net-introduce-DST_NOPEER-dst-flag.patch
 + bugfix/all/rtc-Fix-alarm-rollover-when-day-or-month-is-out-of-r.patch
++ bugfix/all/l2tp-ensure-sk-dst-is-still-valid.patch



More information about the Kernel-svn-changes mailing list