[kernel] r17415 - in dists/lenny/linux-2.6/debian: . patches/bugfix/all

[Dann Frazier]

Author: dannf
Date: Mon May 16 00:58:23 2011
New Revision: 17415

Log:
libsas: fix runaway error handler problem

Added:
   dists/lenny/linux-2.6/debian/patches/bugfix/all/libsas-fix-runaway-error-handler-problem
Modified:
   dists/lenny/linux-2.6/debian/changelog

Modified: dists/lenny/linux-2.6/debian/changelog
==============================================================================
--- dists/lenny/linux-2.6/debian/changelog	Mon May 16 00:58:16 2011	(r17414)
+++ dists/lenny/linux-2.6/debian/changelog	Mon May 16 00:58:23 2011	(r17415)
@@ -23,6 +23,7 @@
     - virtio: set pci bus master enable bit
     - [s390] keyboard: integer underflow bug
     - ocfs2_connection_find() returns pointer to bad structure
+    - libsas: fix runaway error handler problem
 
  -- Ben Hutchings <ben at decadent.org.uk>  Mon, 29 Nov 2010 02:01:24 +0000
 

Added: dists/lenny/linux-2.6/debian/patches/bugfix/all/libsas-fix-runaway-error-handler-problem
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ dists/lenny/linux-2.6/debian/patches/bugfix/all/libsas-fix-runaway-error-handler-problem	Mon May 16 00:58:23 2011	(r17415)
@@ -0,0 +1,30 @@
+commit 3f51182e8c7a3dc5415f4b31811f1fa1ab4d27e9
+Author: James Bottomley <James.Bottomley at suse.de>
+Date:   Thu Jan 20 17:26:44 2011 -0600
+
+    libsas: fix runaway error handler problem
+    
+    commit 9ee91f7fb550a4c82f82d9818e42493484c754af upstream.
+    
+    libsas makes use of scsi_schedule_eh() but forgets to clear the
+    host_eh_scheduled flag in its error handling routine.  Because of this,
+    the error handler thread never gets to sleep; it's constantly awake and
+    trying to run the error routine leading to console spew and inability to
+    run anything else (at least on a UP system).  The fix is to clear the
+    flag as we splice the work queue.
+    
+    Signed-off-by: James Bottomley <James.Bottomley at suse.de>
+    Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
+
+diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
+index a8e3ef3..c8508ca 100644
+--- a/drivers/scsi/libsas/sas_scsi_host.c
++++ b/drivers/scsi/libsas/sas_scsi_host.c
+@@ -648,6 +648,7 @@ void sas_scsi_recover_host(struct Scsi_Host *shost)
+ 
+ 	spin_lock_irqsave(shost->host_lock, flags);
+ 	list_splice_init(&shost->eh_cmd_q, &eh_work_q);
++	shost->host_eh_scheduled = 0;
+ 	spin_unlock_irqrestore(shost->host_lock, flags);
+ 
+ 	SAS_DPRINTK("Enter %s\n", __func__);