[linux] 01/02: usbvision: fix overflow of interfaces array (CVE-2015-7833)

[debian-kernel at lists.debian.org]

This is an automated email from the git hooks/post-receive script.

benh pushed a commit to branch jessie-security
in repository linux.

commit ab9c63b1b1289bc4f00187919fac3336289cf536
Author: Ben Hutchings <ben at decadent.org.uk>
Date:   Sun Nov 8 14:38:26 2015 +0000

    usbvision: fix overflow of interfaces array (CVE-2015-7833)
---
 debian/changelog                                   |  1 +
 ...sbvision-fix-overflow-of-interfaces-array.patch | 31 ++++++++++++++++++++++
 debian/patches/series                              |  1 +
 3 files changed, 33 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 85b1e2b..5a70608 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,7 @@ linux (3.16.7-ckt11-1+deb8u6) UNRELEASED; urgency=medium
   * KEYS: Fix crash when attempt to garbage collect an uninstantiated keyring
     (CVE-2015-7872)
   * KEYS: Don't permit request_key() to construct a new keyring
+  * usbvision: fix overflow of interfaces array (CVE-2015-7833)
 
  -- Salvatore Bonaccorso <carnil at debian.org>  Tue, 20 Oct 2015 19:12:50 +0200
 
diff --git a/debian/patches/bugfix/all/usbvision-fix-overflow-of-interfaces-array.patch b/debian/patches/bugfix/all/usbvision-fix-overflow-of-interfaces-array.patch
new file mode 100644
index 0000000..f6bc4fb
--- /dev/null
+++ b/debian/patches/bugfix/all/usbvision-fix-overflow-of-interfaces-array.patch
@@ -0,0 +1,31 @@
+From: Oliver Neukum <oneukum at suse.com>
+Date: Tue, 27 Oct 2015 12:42:38 +0100
+Subject: usbvision fix overflow of interfaces array
+Origin: https://bugzilla.novell.com/attachment.cgi?id=653350
+
+This fixes the crash reported in:
+http://seclists.org/bugtraq/2015/Oct/35
+The interface number needs a sanity check.
+
+Signed-off-by: Oliver Neukum <oneukum at suse.com>
+[bwh: Backported to 3.16: adjust context]
+---
+ drivers/media/usb/usbvision/usbvision-video.c | 7 +++++++
+ 1 file changed, 7 insertions(+)
+
+--- a/drivers/media/usb/usbvision/usbvision-video.c
++++ b/drivers/media/usb/usbvision/usbvision-video.c
+@@ -1536,6 +1536,13 @@ static int usbvision_probe(struct usb_in
+ 	printk(KERN_INFO "%s: %s found\n", __func__,
+ 				usbvision_device_data[model].model_string);
+ 
++	/*
++	 * this is a security check.
++	 * an exploit using an incorrect bInterfaceNumber is known
++	 */
++	if (ifnum >= USB_MAXINTERFACES || !dev->actconfig->interface[ifnum])
++		return -ENODEV;
++
+ 	if (usbvision_device_data[model].interface >= 0)
+ 		interface = &dev->actconfig->interface[usbvision_device_data[model].interface]->altsetting[0];
+ 	else
diff --git a/debian/patches/series b/debian/patches/series
index f4d3cd2..568e5b0 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -655,3 +655,4 @@ bugfix/all/Initialize-msg-shm-IPC-objects-before-doing-ipc_addid.patch
 bugfix/all/KEYS-Fix-race-between-key-destruction-and-finding-a-.patch
 bugfix/all/KEYS-Fix-crash-when-attempt-to-garbage-collect-an-un.patch
 bugfix/all/KEYS-Don-t-permit-request_key-to-construct-a-new-key.patch
+bugfix/all/usbvision-fix-overflow-of-interfaces-array.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/kernel/linux.git