[linux] 03/04: debian/bin/buildcheck.py: Add check for symbols with version CRC of 0

[debian-kernel at lists.debian.org]

This is an automated email from the git hooks/post-receive script.

benh pushed a commit to branch master
in repository linux.

commit 2661eeaf784e66a38785493c47455a9c98642ae5
Author: Ben Hutchings <ben at decadent.org.uk>
Date:   Fri Dec 2 01:03:16 2016 +0000

    debian/bin/buildcheck.py: Add check for symbols with version CRC of 0
---
 debian/bin/buildcheck.py | 12 ++++++++++--
 debian/changelog         |  1 +
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/debian/bin/buildcheck.py b/debian/bin/buildcheck.py
index f9fa48b..5cd0d8a 100755
--- a/debian/bin/buildcheck.py
+++ b/debian/bin/buildcheck.py
@@ -56,11 +56,19 @@ class CheckAbi(object):
         ret = 0
 
         new = Symbols(open(self.filename_new))
+        unversioned = [name for name in new if new[name].version == '0x00000000']
+        if unversioned:
+            out.write("ABI is not completely versioned!  Refusing to continue.\n")
+            out.write("\nUnversioned symbols:\n")
+            for name in sorted(unversioned):
+                self.SymbolInfo(new[name]).write(out, False)
+            ret = 1
+
         try:
             ref = Symbols(open(self.filename_ref))
         except IOError:
-            out.write("Can't read ABI reference.  ABI not checked!  Continuing.\n")
-            return 0
+            out.write("Can't read ABI reference.  ABI not checked!\n")
+            return ret
 
         symbols, add, change, remove = self._cmp(ref, new)
 
diff --git a/debian/changelog b/debian/changelog
index 9f284d8..716e566 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,6 +15,7 @@ linux (4.9~rc7-1~exp1) UNRELEASED; urgency=medium
     - Revert upstream changes moving exports to assembly sources
     - [x86] kbuild: enable modversions for symbols exported from assembly
     - Revert "Fix subtle CONFIG_MODVERSIONS problems"
+  * debian/bin/buildcheck.py: Add check for symbols with version CRC of 0
 
  -- Uwe Kleine-König <ukleinek at debian.org>  Thu, 17 Nov 2016 09:55:16 +0100
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/kernel/linux.git