[linux] 01/03: Drop "default exported asm symbols to zero"

debian-kernel at lists.debian.org debian-kernel at lists.debian.org
Sat Dec 3 03:32:10 UTC 2016


This is an automated email from the git hooks/post-receive script.

benh pushed a commit to branch master
in repository linux.

commit 34594185e1db1b0fb88e644a323e240eb2d98ec0
Author: Ben Hutchings <ben at decadent.org.uk>
Date:   Sat Dec 3 01:45:17 2016 +0000

    Drop "default exported asm symbols to zero"
    
    This caused *all* symbol version CRCs to be zero in modules on amd64.
---
 debian/changelog                                   |  1 -
 .../all/default-exported-asm-symbols-to-zero.patch | 32 ----------------------
 debian/patches/series                              |  1 -
 3 files changed, 34 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 995d696..33e30eb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -17,7 +17,6 @@ linux (4.9~rc7-1~exp1) UNRELEASED; urgency=medium
     - [powerpc] Remove Mac-on-Linux hooks
     - [powerpc*] Fix missing CRCs, add yet more asm-prototypes.h declarations
     - Re-enable CONFIG_MODVERSIONS in a slightly weaker form
-    - default exported asm symbols to zero
     - module: Disable matching missing version CRC
   * debian/bin/buildcheck.py: Add check for symbols with version CRC of 0
 
diff --git a/debian/patches/bugfix/all/default-exported-asm-symbols-to-zero.patch b/debian/patches/bugfix/all/default-exported-asm-symbols-to-zero.patch
deleted file mode 100644
index 8079cca..0000000
--- a/debian/patches/bugfix/all/default-exported-asm-symbols-to-zero.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From: Arnd Bergmann <arnd at arndb.de>
-Date: Fri, 02 Dec 2016 13:40:27 +0100
-Subject: default exported asm symbols to zero
-Origin: https://lkml.kernel.org/r/8452191.39CeLIHTBT@wuerfel
-
-With binutils-2.16 and before, a weak missing symbol was kept during the
-final link, and a missing CRC for an export would lead to that CRC
-being treated as zero implicitly. With binutils-2.17, the crc
-symbol gets dropped, and any module trying to use it will fail to
-load.
-
-This sets the weak CRC symbol to zero explicitly, making it defined
-in vmlinux, which in turn lets us load the modules referring to
-that CRC.
-
-The comment above the __CRC_SYMBOL macro suggests that this was
-always the intention, although it also seems that all symbols
-defined in C have a correct CRC these days, and only the exports
-that are now done in assembly need this.
-
-Signed-off-by: Arnd Bergmann <arnd at arndb.de>
----
---- a/include/asm-generic/export.h
-+++ b/include/asm-generic/export.h
-@@ -54,6 +54,7 @@ KSYM(__kstrtab_\name):
- KSYM(__kcrctab_\name):
- 	__put KSYM(__crc_\name)
- 	.weak KSYM(__crc_\name)
-+	.set KSYM(__crc_\name), 0
- 	.previous
- #endif
- #endif
diff --git a/debian/patches/series b/debian/patches/series
index 0cedc6b..0c31552 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -103,7 +103,6 @@ bugfix/x86/x86-kbuild-enable-modversions-for-symbols-exported-f.patch
 bugfix/powerpc/powerpc-remove-mac-on-linux-hooks.patch
 bugfix/powerpc/powerpc-fix-missing-crcs-add-yet-more-asm-prototypes.patch
 bugfix/all/re-enable-config_modversions-in-a-slightly-weaker-fo.patch
-bugfix/all/default-exported-asm-symbols-to-zero.patch
 bugfix/all/module-disable-matching-missing-version-crc.patch
 
 # ABI maintenance

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/kernel/linux.git



More information about the Kernel-svn-changes mailing list