[kgb-maintainers] Bug#700319: kgb-bot should allow to use the real name or entire mail address in messages

Wolodja Wentland debian at babilen5.org
Mon Feb 11 16:05:38 UTC 2013


Package: kgb-bot
Version: 1.25-1
Severity: wishlist

Dear Maintainer,

the current way in which author names are extracted from commit logs leads to
suboptimal commit messages in some cases. This is, in particular, the case if
somebody committed as, say, "debian at example.com". Currently this would result
in commit messages such as:

    debian master file1 file2 * wonderful changes that improve everything

It is hard or even impossible to figure out /who/ actually commited to the
repository and people would have to check the log manually. I would like to be
able to configure kgb-bot to either show the entire mail address or, even
better, the real name of the user.

The "bug" seems to be that the regular expression to parse reflogs in
lib/App/KGB/Client/Git.pm uses "^author .+ <([^>]+@[^>]+>/;" to extract
author. I would propose to change this to either:

    * "^author (.+) <[^>]+@[^>]+>/;"    # real name
    * "^author .+ <([^>]+@[^>]+)>/;"    # entire address

It would probably be best to simply give end users a way to configure this
themselves (either by letting them define the regex themselves or by providing
a number of defaults).

Thanks for your work and may you have a nice day!


-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf-8, LC_CTYPE=en_GB.utf-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



More information about the kgb-maintainers mailing list