[kgb-maintainers] Bug#772735: Bug#772735: kgb-client hits an assert on SVN repo path with a tailing "/"

[gregor herrmann]

On Wed, 10 Dec 2014 17:04:56 +0100, Pierre Schweitzer wrote:

> Package: kgb-client
> Severity: important
> Tags: upstream
> 
> This report follows the report on Ubuntu LP:
> https://bugs.launchpad.net/ubuntu/+source/kgb-bot/+bug/1400453
> 
> When calling the kgb-client on a SVN repo with a tailing "/", the client will
> hit an assert:
> perl: /build/buildd/subversion-1.8.8/subversion/libsvn_subr/dirent_uri.c:972:
> svn_dirent_join: Assertion `svn_dirent_is_canonical(base, pool)' failed.
> Aborted
> 
> The solution to fix it is to remove said tailing "/".
> 
> Because SVN provides the path with the tailing "/" in case of a hook, it would
> be better if kgb-client chomps it.

Leading or trailing? I suppose the former, as you wrote in launchpad.

Anyway, I can't confirm this behaviour.
Luckily my post-commit hook writes a log so I could look at the last
invocation, which looks like:

/usr/bin/kgb-client --conf /home/groups/$CONFIG.conf /var/svnroot/$REPO 1588

(From your LP bug:
kgb-client --conf /etc/kgb-client/kgb-reactos.conf --repository svn /srv/svn/reactos/ 65590
)

Running it again there is no output and the return code is 0.
(And I see the commit message in the channel :))

Or is it the trailing / after all?

% /usr/bin/kgb-client --conf /home/groups/$CONFIG.conf /var/svnroot/$REPO/ 1588
perl: /build/subversion-IvrZTj/subversion-1.8.10/subversion/libsvn_subr/dirent_uri.c:972: svn_dirent_join: Assertion `svn_dirent_is_canonical(base, pool)' failed.

+ coredump.

Ok, here we are.


I'm just not so sure where the trailing / in your invocation comes from.

Unless I'm mistaken, the subversion version that passed the path
without a trailing slash to the post-commit hook in my example was
1.8.9-2, and KGB was at version 1.33-1.

But yes, having the client strip the trailing / from the path might
be a good idea.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bettina Wegner: Ueber den Berg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/kgb-maintainers/attachments/20141210/09fd6fdf/attachment.sig>