[Letsencrypt-devel] Bug#810720: libdpkg-perl: check_patches_applied does not apply patches if the first patch emits a warning
hlieberman at setec.io
Sat Jan 16 22:51:06 UTC 2016
Apollon Oikonomopoulos <apoikos at debian.org> writes:
> On 21:22 Tue 12 Jan , Guillem Jover wrote:
>> In any case you should fix this in the source package, either by
>> merging the hunks into a single patch (what's the point of a patch
>> series correcting the same previously introduced changes anyway? :),
>> or by splitting the different patches into independent files. Or
>> rearranging the patch as you mentioned.
> I agree. I'm Cc'ing the package maintainers, since I'm not directly
> involved with the package myself.
Indeed! The rather odd patch series came from me collapsing a branch of
patches into a single file from the upstream source control, rather than
melding the patch series into a single patch before dumping it into the
file. Since quilt was happy with it, I didn't think to check other
problems that might have caused.
The patch has been since applied upstream, so the troublesome file was
deleted in the last upload of letsencrypt.
I'm fine considering this one as user-error and having it closed,
Guillem, unless you want it open for some other reason.
More information about the Letsencrypt-devel