[Letsencrypt-devel] Bug#824928: Bug#824928: letsencrypt.sh: move the default position of the domains file to /etc/letsencrypt.sh/

[Daniel Beyer]

Hi Mattia,

On Sat, 2016-05-21 at 15:58 +0200, Daniel Beyer wrote:
> (...)
>
> It looks like ${DOMAINS_TXT} can not be set or overridden in config.sh.
> But it should be rather easy to add this feature to letsencrypt.sh. I'll
> work on a patch and propose it upstream. In past upstream was very nice
> with accepting improvements to letsencrypt.sh. I'll let you know about
> the progress of this.

I opened a PR for upstream [1], based on the initial work you gave me.
It might take a bit till upstream reacts to it, but I think chances are
good it will be accepted.
[1] https://github.com/lukas2511/letsencrypt.sh/pull/204

I started working on updating our packaging in a new branch
wip/dabe/domains.txt-in-etc. But I have the feeling, that mentioning the
change in d/NEWS is not enough.
So i came up with the following idea (not implemented, yet):
During upgrade we check if a /var/lib/letsencrypt.sh/domains.txt exists
and if so add an extra config file in /etc/letsencrypt.sh/conf.d/ to
automatically reconfigure letsencrypt.sh back to the old location. With
this we would not break things for our existing users.
Do you have an other idea or opinion how to deal with this?

An other question is whether or not we should start shipping
a /etc/letsencrypt.sh/domains.txt. I would prefer to do that, with a
small header (lines containing '#' are ignored) outlining the purpose
and the format of this domains.txt file. What do you think?


Greetings
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/letsencrypt-devel/attachments/20160521/211518aa/attachment.sig>