[Letsencrypt-devel] Bug#824928: letsencrypt.sh: move the default position of the domains file to /etc/letsencrypt.sh/

[Mattia Rizzolo]

shame on me.

I've been quite busy over the last month, due to university exam stuff
(and will be in vacation next week), but I had some spare cycles now so
I looked at this.

On Mon, Jun 13, 2016 at 10:47:56AM +0200, Daniel Beyer wrote:
> I pushed changes to this new branch (based on current debian/master):
> wip/dabe/domains.txt-in-etc-maint-scripts
> 
> It adds maintainer scripts to deal with domains.txt as well as the
> PRIVATE_KEY to ACCOUNT_KEY renaming. I also updated d/NEWS to mention
> what happens during the upgrade and updated d/changelog accordingly
> using '# gbp dch --snapshot --auto'. Fell free to push additional
> changes to it and/or share your opinion about those scripts - or simply
> merge it into debian/master.

lgtm.
the way to grab vars from le.sh looks quite convoluted, but I see what
you did.  apparently it doesn't emit BASEDIR in -e's output, so it's
kinda hard to do checks on it.

fine by me.  I added a couple of changes (mostly wording (imho)
improvements), please look at that.

> Note that I did not do anything regarding installing a domains.txt
> in /etc/letsencrypt.sh.

I also tackled this.
I added a small entry there pointing to upstream's doc.

For the "show a message if domains.txt's empty" foo I quickly cooked the
attached thing.  What do you think of it?
If you think that's sane enough it'd be helpful if you could try to
forward it upstream and/or commit (with a nicer message maybe...) to the
packaging.
As I said next week I'll be out (and the one after I'll have to catch up
for having been a week out), so I can't really look into this so soon
again…

> if there will be work left to get 0.2.0-1 ready for an upload to unstable.

I'd just like this bit done…

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: print_msg_on_empty_domains_list.patch
Type: text/x-diff
Size: 1225 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/letsencrypt-devel/attachments/20160722/7ca649f9/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/letsencrypt-devel/attachments/20160722/7ca649f9/attachment.sig>