[Letsencrypt-devel] Bug#826145: letsencrypt.sh: Ship lighttpd module?

[Elrond]

Hi,


On Sun, Sep 04, 2016 at 20:23:11 +0000, Mattia Rizzolo wrote:
> Hi,
> 
> getting back to this getting-old bug...

great.


> On Tue, Jun 14, 2016 at 05:01:59PM +0200, Elrond wrote:
[...]
> > I have filed a debian bug to create a directory for
> > snippets that are auto-activated in the default virtual
> > host. #822792
> 
> I find this behaviour disturbing, and also far from what I come to
> expect from a debian package (istr this is also written in some policy
> somewhere...)
> 
> I subscribed to that bug (and also replied???), but let's get to this.

I will try to get to that bug soon again.

Luckily the maintainers start to understand the issue.


[...]
> > I have attached a new version of the config snippet.
> > Note: I have renamed it from 10-* to 50-*, so that it gets
> > loaded much later and has a good chance of overriding most
> > things.
> 
> So, you can see here a wip:
> https://anonscm.debian.org/git/letsencrypt/letsencrypt.sh.git/commit/?h=debian/wip/lighttpd&id=dad41045dea17c7fe0814c3f678e93b0c5587656
> do you really think that's going to be useful to somebody?

Yes!
It will help admins by not having to rule their own config. 
They can just use the one and be sure, that it handles the
basics.


> Should a README be also provided (or the comment there expanded) saying
> what shall be done to have that enabled, or are lighttpd admins clever
> enough to figure it out themselves?

That looks great.

They are usually clever enough. But having a comment in a
README and/or the package description might help.


> On a related note, adding two more files in debian/* is not going to
> hurt us, but that directory is getting quite crowded in such a small
> package u.U :D

Some packaging comments:

* Some packages put extra files into debian/files/. I don't
  know, whether this is allowed/standard/whatever, but it
  might make things easier.

* If the letsencrypt.sh-lighttpd basicly only ships one
  file, and a comment/README on how to use it. You might
  just include it in the main package. That will unclutter
  things also.
  Then it's basicly a "We have it, if you need it".

* If you include it in the main package, you probably
  should add "Enhances: lighttpd" to its description.


Cheers

    Elrond