[Letsencrypt-devel] Bug#879276: [PATCH] drop unnecessary -O--buildsystem=golang args

Michael Stapelberg stapelberg at debian.org
Sat Oct 21 11:58:22 UTC 2017


Source: acmetool
Severity: normal
Tags: patch

Please consider merging the attached patch.

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armel, mipsel, arm64

Kernel: Linux 4.13.0-1-amd64 (SMP w/12 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
>From 8e13e542f00f71119359264b85cbe854469e3020 Mon Sep 17 00:00:00 2001
From: Michael Stapelberg <stapelberg at debian.org>
Date: Sat, 21 Oct 2017 13:55:45 +0200
Subject: [PATCH] Drop unnecessary -O--buildsystem=golang args.

They confuse casual readers of the packaging.
---
 debian/rules | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/rules b/debian/rules
index 63a6e98..33dac26 100755
--- a/debian/rules
+++ b/debian/rules
@@ -11,14 +11,14 @@ GO_LDFLAGS += -X github.com/hlandau/buildinfo.RawBuildInfo=$(shell echo -n 'acme
 	dh $@ --buildsystem=golang --with=golang,apache2
 
 override_dh_auto_build:
-	dh_auto_build -O--buildsystem=golang -- -ldflags "$(GO_LDFLAGS)"
+	dh_auto_build -- -ldflags "$(GO_LDFLAGS)"
 
 # Disable OCSP test to avoid network access
 override_dh_auto_test:
-	dh_auto_test -O--buildsystem=golang -- -run '^Test([^O]|O[^C]|OC[^S]|OCS[^P])'
+	dh_auto_test -- -run '^Test([^O]|O[^C]|OC[^S]|OCS[^P])'
 
 override_dh_auto_install:
-	dh_auto_install -O--buildsystem=golang -- --no-source
+	dh_auto_install -- --no-source
 	mkdir -p debian/acmetool/usr/share/man/man8
 	debian/acmetool/usr/bin/acmetool --help-man > debian/acmetool/usr/share/man/man8/acmetool.8
 
-- 
2.14.2



More information about the Letsencrypt-devel mailing list