[Letsencrypt-devel] Bug#894025: python-certbot-dns-cloudflare: Fails to build from source

[Andrew Starr-Bochicchio]

On Sun, Mar 25, 2018 at 11:15 PM, Harlan Lieberman-Berg <
hlieberman at debian.org> wrote:

> Hm, so, we've never shipped the testdata.  All the way back to the first
> tag (0.0.0.dev20151104-1), we've removed the testdata.  It's only for the
> test cases, so we don't ship it out in the debs.
>

It looks like the test data slipped back into the package at some point.
Inspecting the 0.21.1-1 from testing:

$ dpkg --contents python3-certbot_0.21.1-1_all.deb | grep rsa512_key.pem
-rw-r--r-- root/root       493 2018-01-25 14:29
./usr/lib/python3/dist-packages/certbot/tests/testdata/rsa512_key.pem

It's not actually clear to me if any of these packages really depend on
that test data. It seems that it is only due to them importing
dns_test_common which defines the key globally.

https://salsa.debian.org/letsencrypt-team/certbot/certbot/blob/master/certbot/plugins/dns_test_common.py#L16

But taking a quick look at the packages that are failing, I don't actually
see KEY referenced in their tests. So we could patch potentially that out
in the main certbot package.


-- Andrew Starr-Bochicchio

   Debian Developer <http://qa.debian.org/developer.php?login=asb>
   Ubuntu Developer <https://launchpad.net/~andrewsomething>
   PGP/GPG Key ID: 3B56E2BBD53FDCB1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/letsencrypt-devel/attachments/20180326/9d42f780/attachment.html>