[Libpst-devel] pst_attach_to_file

[Nigel Horne]

This code appears in 0.5.1 of libpst:

if (ptr != NULL) {
      size = _pst_ff_getID2data(pf, ptr, &h);
} else {
      DEBUG_WARN(("Couldn't find ID pointer. Cannot save attachment to file\n"));
}
attach->size = size;

It would be better to return at the "cannot save attachment error", otherwise
size is used with an undefined value. An acceptable alternative would be to set
size to 0 after the warning message.

-Nigel Horne