[Libpst-devel] pst_load_extended_attributes memory leak

[Joseph Nahmias]

On Wed, Apr 26, 2006 at 02:22:17PM +0100, Nigel Horne wrote:
> wt is never freed
> 
> -Nigel Horne
> 
> *** Olibpst.c	Wed Apr 26 14:20:31 2006
> --- libpst.c	Wed Apr 26 14:20:46 2006
> ***************
> *** 443,448 ****
> --- 443,449 ----
>   	memset(wt, 0, tint+2);
>   	memcpy(wt, &(headerbuffer[xattrib.extended+sizeof(tint)]), tint);
>   	ptr->data = _pst_wide_to_single(wt, tint);
> + 	free(wt);
>   	DEBUG_INDEX(("Read string (converted from UTF-16): %s\n", ptr->data));
>         } else {
>   	DEBUG_INDEX(("Cannot read outside of buffer [%i !< %i]\n", xattrib.extended, hsize));

Agreed.

--Joe