Bug in TYPE_FULL ???

sonntag benoit sonntag at icps.u-strasbg.fr
Sun Aug 9 23:54:38 UTC 2009


Mildred Ki'Lya <ml.mildred593 at gmail.com> a écrit :

> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: quoted-printable
>
> Hi,
>
> I found something quite disturbing in TYPE_FULL (while grepping through
> the source tree):
>
>
> Section TYPE
>
>   + flag:UINTEGER_8;
>   // 7 6 5 4 3 2 1 0
>   //     | | | | | +- 0:Reference / 1:Expanded
>   //     | | | | +--- 0:Reference / 1:Expanded (by default)
>   //     | | | +----- 0:Normal    / 1:Strict
>   //     | | +------- 0:Normal    / 1:Strict (by default)
>   //     | +--------- 0:Normal    / 1:Temporary
>   //     +----------- 0:Normal    / 1:Old generic
>
> Section Public
>
>   - expanded_bit        :UINTEGER_8 := 000001b;
>   - default_expanded_bit:UINTEGER_8 := 000010b;
>   - strict_bit          :UINTEGER_8 := 000100b;
>   - default_strict_bit  :UINTEGER_8 := 001000b;
>   - expanded_ref_bit    :UINTEGER_8 := 010000b;
>   - generic_bit         :UINTEGER_8 := 100000b;
>
>   //
>   // Access.
>   //
>
>   - is_expanded          :BOOLEAN <- (flag & expanded_bit        ) != 0;
>   - is_default_expanded  :BOOLEAN <- (flag & default_expanded_bit) != 0;
>   - is_strict            :BOOLEAN <- (flag & strict_bit          ) != 0;
>   - is_default_strict    :BOOLEAN <- (flag & default_expanded_bit) != 0;
>   - is_expanded_ref      :BOOLEAN <- (flag & expanded_ref_bit    ) != 0;
>   - is_generic           :BOOLEAN <- (flag & generic_bit         ) != 0;
>
>
>
>
> I think you got the ideas, flags.
>
> Now, what bothers me is the following slot:
>
>   - is_default_strict    :BOOLEAN <- (flag & default_expanded_bit) != 0;
>
> I think it should be:
>
>   - is_default_strict    :BOOLEAN <- (flag & default_strict_bit  ) != 0;
>
>
>
> What do you think ?
>

Yes, ok!

> --
> Mildred Ki'Lya
> ╭───────── mildred593@online.fr ──────────
> │ Jabber, GoogleTalk: <mildred at jabber.fr>
> │ Website: <http://ki.lya.online.fr>           GPG ID: 9A7D 2E2B
> │ Fingerprint: 197C A7E6 645B 4299 6D37 684B 6F9D A8D6 9A7D 2E2B
>
>
>




More information about the Lisaac-devel mailing list