[lockdev-devel] [PATCH] reserve some space to avoid buffer overflow

Ludwig Nussel ludwig.nussel at suse.de
Fri Apr 23 11:58:43 UTC 2010


this should really be handled by the _dl_filename_* functions
---
 src/lockdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lockdev.c b/src/lockdev.c
index 88305e9..84c0902 100644
--- a/src/lockdev.c
+++ b/src/lockdev.c
@@ -488,7 +488,7 @@ _dl_check_devname (const char *devname)
 	}
 	if ( strcmp( p, "tty") == 0 )
 		p = ttyname( 0); /* this terminal, if it exists */
-	if (((l = strlen(p)) == 0) || (l > (MAXPATHLEN - strlen(LOCK_PATH))))
+	if (((l = strlen(p)) == 0) || (l > (MAXPATHLEN - strlen(LOCK_PATH) - 10)))
 		return NULL;
 	if ((m = malloc(++l)) == NULL)
 		return NULL;
-- 
1.6.4.2




More information about the lockdev-devel mailing list