[lockdev-devel] [PATCH 18/19] use automake/autoconf/libtool

[Ludwig Nussel]

Karel Zak wrote:
> On Thu, Feb 25, 2010 at 11:02:15AM +0100, Ludwig Nussel wrote:
> > +AC_INIT([lockdev],[1.0.3],[lockdev-devel at lists.alioth.debian.org])
> > +AC_CONFIG_SRCDIR([src/lockdev.c])
> > +AM_CONFIG_HEADER([config.h])
> > +AC_CONFIG_MACRO_DIR([m4])
> > +
> > +AC_PREREQ(2.53)
> > +AC_CANONICAL_HOST
> > +AM_INIT_AUTOMAKE([1.6 foreign no-dist-gzip dist-bzip2 silent-rules -Wall])
>                      ^^^                                  ^^^^^^^^^^
>  I think silent-rules are supported since AM 1.11. It's maybe more
>  robust to use
> 
> m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])],
>                             [AC_SUBST([AM_DEFAULT_VERBOSITY], [1])])

Indeed. Thanks!

> > diff --git a/src/Makefile.am b/src/Makefile.am
> > new file mode 100644
> > index 0000000..0584304
> > --- /dev/null
> > +++ b/src/Makefile.am
> > @@ -0,0 +1,11 @@
> > +sbin_PROGRAMS = lockdev
> > +
> > +include_HEADERS = lockdev.h baudboy.h ttylock.h
> > +
> > +lockdev_SOURCES = sample.c
>                      ^^^^^^^
>  the name of this file is ugly. It would be better to use lockdev.c
>  for the util and liblockdev.c for the library (or so).

Yes.

> > +lockdev_LDADD = liblockdev.la
> > +
> > +lib_LTLIBRARIES = liblockdev.la
> > +liblockdev_la_SOURCES = lockdev.c
> > +
> > +liblockdev_la_LDFLAGS = -version-info 1:3:0
> 
>  what about symbols versioning, so:

I've thought about that too. Since I've removed the inline ttylock
functions and made them library symbols having versioned symbols for
them makes sense.

cu
Ludwig

-- 
 (o_   Ludwig Nussel
 //\   
 V_/_  http://www.suse.de/
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)