[lockdev-devel] [PATCH] locking of non-devices doesn't work with SVr4 lock files

[Roger Leigh]

Thanks, I've now applied (I think) all your patches to date and pushed
them.  WRT the removal of support for devices outside of /dev, this
support is present in the minicom locking code, so maybe we should
keep this?  So long as we are using the device major and minor and not
the name for locking, this should work just fine.

I'm also not sure about some of the special-casing in
_dl_check_devname, for example "/dev/tty"/"tty".  While locking
/dev/tty makes little sense, assuming that this is ttyname(0)
is not always going to be a valid assumption (it could be closed).
I'm not sure exactly why a simple stat(2) of the device not is not
entirely sufficient here (which we already do).  What special cases
does this function cover?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/lockdev-devel/attachments/20100314/68b91c2b/attachment.pgp>