[Logcheck-devel] Re: [Logcheck-commits] CVS logcheck/debian

[maks attems]

On Tue, 20 Jul 2004, CVS User ttroxell wrote:

> Update of /cvsroot/logcheck/logcheck/debian
> In directory haydn:/tmp/cvs-serv9195/debian
> 
> Modified Files:
> 	changelog logcheck.postinst logcheck.preinst 
> Log Message:
> -moved adduser to postinst. seems to work for me, but please test!
> 	-fixing #258735
 
looks good, tested on my broken logcheck machine,
which had no user, logcheck works now there! :)
but i can't test it for an direct upgrade from
woody, no woody machine left
 
> --- /cvsroot/logcheck/logcheck/debian/logcheck.postinst	2004/07/19 13:57:11	1.18
> +++ /cvsroot/logcheck/logcheck/debian/logcheck.postinst	2004/07/21 02:57:15	1.19
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  
> -# $Id: logcheck.postinst,v 1.18 2004/07/19 13:57:11 maks-guest Exp $
> +# $Id: logcheck.postinst,v 1.19 2004/07/21 02:57:15 ttroxell Exp $
>  
>  set -e
>  
> @@ -27,6 +27,14 @@
>  
>  case "$1" in
>      configure)
> +	# Add logcheck user
> +    	if dpkg --compare-versions "$2" eq 1.2.19; then
> +	   usermod -d /var/lib/logcheck logcheck > /dev/null 2>&1 || true
> +    	elif dpkg --compare-versions "$2" lt 1.2.24; then
> +	  adduser --quiet --system --no-create-home --group \
> +	      --home /var/lib/logcheck logcheck || true
> +	  adduser --quiet logcheck adm || true
> +	fi
>  	# Remove old directory
>  	if dpkg --compare-versions "$2" lt "1.1.1-13.2"; then
>  	    if [ -d /var/cache/logcheck ]; then
> @@ -42,7 +50,7 @@
>          if [ "$2" = "" -a ! -f /etc/logcheck/header.txt ]; then
>            cp -p /usr/share/logcheck/header.txt /etc/logcheck
>          fi
> -	if dpkg --compare-versions "$2" lt 1.2.23; then
> +	if dpkg --compare-versions "$2" lt 1.2.24; then
>      	  # Fix Permissions
>      	  chown -R logcheck:logcheck /var/lib/logcheck  || true
>            chgrp -R logcheck /etc/logcheck || true

me thinks that the special casing of 1.2.19 makes no more sense,
it should be removed out of simplicity and robustness?
what do you think?

a++ maks

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040721/465fc285/attachment.pgp