[Logcheck-devel] Re: [Logcheck-commits] CVS logcheck/src

[Todd Troxell]

Cool, good find.  I think actually -r is all that is needed as it tests for
existence as well as readability.


On Mon, May 17, 2004 at 01:33:23PM +0200, Gerfried Fuchs wrote:
> * Todd Troxell <ttroxell at debian.org> [2004-05-15 06:22]:
> > On Sat, May 15, 2004 at 11:59:47AM +0200, maks attems wrote:
> >> anyway your patch makes current logcheck fail,
> >> because we have _no_ /etc/logcheck/footer.txt.
> >> so cat fails P-)
> > 
> > It will not fail because of the if above:
> > 
> > if [ -f /etc/logcheck/footer.txt ] ; then
> 
>  Uhm, -f tests only for file existence, not for readability. I would
> suggest to change it to the following:
> 
> if [ -f /etc/logcheck/footer.txt -a -r /etc/logcheck/footer.txt ] ; then
> 
>  Just to be sure,
> Alfie
> -- 
> Wo wir schon bei Schn?ppchenbestrafungen sind: ich finde ? 307 StGB hat ein
> recht ordentliches Preis-Leistungs-Verh?ltnis. Soviel Bums f?r sowenig Strafe
> gibt sonst nirgendwo.
>                         -- Holger Lembke in de.soc.recht.misc



-- 
[   Todd J. Troxell                                         ,''`.
      Student, Debian GNU/Linux Developer, SysAdmin, Geek  : :' :
      http://debian.org || http://rapidpacket.com/~xtat    `. `' 
                                                             `-     ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040517/d7391b90/attachment.pgp