Bug#273433: [Logcheck-devel] Bug#273433: logcheck: odd behaviour with perdition rules
Gerfried Fuchs
alfie at ist.org
Tue Oct 12 06:37:10 UTC 2004
* maks attems <debian at sternwelten.at> [2004-09-27 10:36]:
> but if you look at the code:
> $SORT -m $TMPDIR/logoutput/* | uniq | sed -e 's/ *$//' | cat \
> > $TMPDIR/logoutput-sorted \
> we strip using sed any trailing whitespace in the logfile.
Wouldn't a "sed -e 's/ +$//'" be perform better? Can someone do a quick
benchmark on that? It might be needed to use 's/ \+$//' or similar, but
I guess you get the idea.
This might help us improving the throughput a little bit. That way it
only does the sed when it really applies, not for every line. Also,
don't we really want to stripp '[[:space:]]' instead of ' ', that is,
including tab stops?
Just a thought.
Alfie
P.S.: Finally uploaded logcheck for woody today, unfortunately it got
tagged as NMU because I'm not in the uploaders field, but I'll send
the -done message the next days, when I've got Joey's ACK again for
accepting the package into the next point release.
--
> Wozu ein Forum, wenn's Usenet gibt?
Umfassender Einblick in die Newsg^H^H^H^H^HForum durch Wegfall von
Scores, Killfile etc
-- Alexander Talos in <3d18e47b$0$20382$3b214f66 at news.univie.ac.at>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20041012/3408b1a3/attachment.pgp
More information about the Logcheck-devel
mailing list