[Logcheck-devel] Re: [Logcheck-commits] CVS logcheck/debian

[maximilian attems]

On Sun, Feb 19, 2006 at 01:52:26PM +0000, CVS User ttroxell wrote:
> 
> bug found upon upgrade of logcheck (found thanks to new rulefile check)
> -User installs logcheck, group of /etc/logcheck get set at postinst
> -User upgrades logcheck _which contains new rulefiles_
> -Because it's an upgrade > 1.2.39, the chgrp never happens

full ack,
so that check has some very nice side effects, cool :)
 
> For now, I'm removing the conditional, which shouldn't be too disruptive.
> I'm also including some changes I accidentally left out of .43 proper, which
> are listed in the prior changelog entry.
> 
> 
> --- /cvsroot/logcheck/logcheck/debian/changelog	2006/02/19 13:09:41	1.551
> +++ /cvsroot/logcheck/logcheck/debian/changelog	2006/02/19 13:52:25	1.552
> @@ -1,3 +1,11 @@
> +logcheck (1.2.43a) unstable; urgency=low
> +
> +  * Bugfix release.  Unconditionalize chgrp -R of /etc/logceck as our
> +    new logfile-unreadability tests revaled some unreadable rule files
> +    upon upgrade.
> +
> + -- Todd Troxell <ttroxell at debian.org>  Sun, 19 Feb 2006 08:32:20 -0500
> +
>  logcheck (1.2.43) unstable; urgency=low
>  
>    [ maximilian attems ]
> --- /cvsroot/logcheck/logcheck/debian/logcheck.postinst	2006/02/16 17:37:50	1.43
> +++ /cvsroot/logcheck/logcheck/debian/logcheck.postinst	2006/02/19 13:52:26	1.44
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  
> -# $Id: logcheck.postinst,v 1.43 2006/02/16 17:37:50 jlps-guest Exp $
> +# $Id: logcheck.postinst,v 1.44 2006/02/19 13:52:26 ttroxell Exp $
>  
>  set -e
>  
> @@ -81,9 +81,11 @@
>  	# chgrp -R logcheck /etc/logcheck || true
>  
>  	# This gets executed even if there is no $2.
> -	if dpkg --compare-versions "$2" lt "1.2.34"; then
> -	  chgrp -R logcheck /etc/logcheck || true
> -	fi
> +	#if dpkg --compare-versions "$2" lt "1.2.34"; then
> +
> +	# Unconditionalizing this for now as we have files that are
> +	# unreadable upon upgrade.  <ttroxell at debian.org>
> +	chgrp -R logcheck /etc/logcheck || true
>  
>      	# Set Permissions on install or upgrade
>  	if [ ! -n "$2" ] || dpkg --compare-versions "$2" lt "1.2.34"; then
>