[Logcheck-devel] Bug#453519: Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

[Russ Allbery]

Frédéric Brière <fbriere at fbriere.net> writes:

> +    [ -e "$CONFFILE" ] || return 0

It probably doesn't matter, but I'd use -f here.

> +    echo "Obsolete conffile $CONFFILE has been modified by you."
> +    echo "Saving as $CONFFILE.dpkg-bak ..."
> +    mv -f "$CONFFILE" "$CONFFILE".dpkg-bak

I would tend to not do this and instead just leave the file in place since
it does still work.  I think it's arguable that moving the file aside such
that it is no longer active would constitute discarding user configuration
in a way that logcheck shouldn't, Policy-wise, do.

Otherwise, looks great here.

-- 
Russ Allbery (rra at debian.org)               <http://www.eyrie.org/~eagle/>