[Ltrace-devel] .gnu.hash patch

Petr Machata pmachata at redhat.com
Mon Jul 17 16:05:08 UTC 2006


On Mon, 2006-07-17 at 08:42 -0700, Steve Fink wrote:
> On 7/17/06, Petr Machata <pmachata at redhat.com> wrote:
> > This patch adds support for .gnu.hash section in ELF binaries.  The
> > section is considered optional, classical .hash section is taken when
> > both are present.  The code is #ifdefed, so it shouldn't make problems
> > on platforms that don't have .gnu.hash support.
> >
> > If there are no objections, I'm going to commit this code.
> 
> Did you mean to include this part?:

Originally yes, but this is more of a cleanup and would be better suited
in another patch.

Anyway, hardcoding version this way seems clumsy to me.  We are on 0.5
now, and nobody remembered to push this since 0.3.32.  We surely are
going to forget about it more regularly in future.

PM

> 
> Index: options.c
> ===================================================================
> --- options.c   (revision 45)
> +++ options.c   (working copy)
> @@ -2,10 +2,6 @@
>  #include "config.h"
>  #endif
> 
> -#ifndef PACKAGE_VERSION
> -# define PACKAGE_VERSION "0.3.32"
> -#endif
> -
>  #include <string.h>
>  #include <stdlib.h>
>  #include <unistd.h>




More information about the Ltrace-devel mailing list