[Ltrace-devel] [PATCH] Fix ppc64 ABI support

Luis Machado luisgpm at linux.vnet.ibm.com
Mon Feb 25 17:40:39 UTC 2008


Hi,

This is an improvement over the previous patch to fix ppc32 failures in
the testsuite.

The patch addresses various issues related to the ABI and alignment
problems related to the use of a 64-bit ltrace to trace 32-bit binaries.

There's also a fix to handle the first call to a function for ppc32,
preventing ltrace from stacking fake function calls.

With this patch, the results are as follows:

- Ltrace64 with 64-bit binaries: 1 failure (unpatched: 8 failures)

Fails happens on parameters.exp - strlen(...).

- Ltrace64 with 32-bit binaries: 2 failures (unpatched: 18 failures) 

Fail happens on parameters.exp - strlen(...).
Fail happens on parameters.exp - func_struct(...) due to alignment
problems with pointers inside structs (still to be fixed).

- Ltrace32 with 32-bit binaries: 2 failures (unpatched: 11 failures)

Fail happens on parameters.exp - strlen(...).
Fail happens on parameters.exp - func_float(...), due to alignment
problems (still to be fixed).

All the failing testcases (except for strlen) have a known fix, but i'm
still investigating the best solution for them. I still have to come up
with a fix to strlen for ppc, if that's ever possible. If not, i might
declare that unsupported for ppc.

I know that there are other problems that need to be addressed (globals
and such), but for now this fixes a great number of failing testcases we
had for ppc, improving ltrace a bit. I hope to contribute additional
fixes in the future. But, for now, is this OK to go in?

Best Regards,

-- 
Luis Machado
Software Engineer 
IBM Linux Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_ppc_abi.diff
Type: text/x-patch
Size: 11375 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/ltrace-devel/attachments/20080225/37995e24/attachment.bin 


More information about the Ltrace-devel mailing list