[Ltrace-devel] [PATCH] Fix ppc64 ABI support

Anderson Lizardo anderson.lizardo at gmail.com
Wed Feb 27 17:35:28 UTC 2008


On Wed, Feb 27, 2008 at 1:01 PM, Luis Machado
<luisgpm at linux.vnet.ibm.com> wrote:
>
>  > Your patch seems to not follow coding style of the rest of the code,
>  > mainly that your conditional blocks look like (GNU style ?):
>
>
> > Also, in a few places you replaced tabs with spaces, which is wrong IMHO.
>
>  Yes, i took the GNU style steps on that. How about the formatting now?

Looks ok to me.

>  Correct me if i'm wrong, but i don't think we could possibly have two
>  functions being printed at the same time concurrently, could we? The
>  solution could be better (working on a better one), but for now i think
>  this does improve things a bit.

I think ltrace does not "switch context" in the middle of argument
printing, so that's OK for me too.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia
Manaus - Brazil



More information about the Ltrace-devel mailing list