[Ltrace-devel] new tree feedback
Zach Welch
zwelch at codesourcery.com
Wed Nov 3 17:32:27 UTC 2010
Here are some potential problems with the new tree:
* --with-libunwind should be --enable-libunwind, given its current
usage; however, --with would be appropriate if it allowed users to
specify the path where that library has been installed.
* The 'testsuite' directory is not being distributed.
* The test suite build system was not updated to use autotools.
* The test suite is not called during 'make check' and 'make distcheck'.
* The test suite is not covered by .gitignore.
* The autogen.sh script is being distributed, but it is meant to be used
only by developers that need to bootstrap the Git repository.
* configure.ac is missing AC_MAINTAINER_MODE which provides the useful
--enable-maintainer-mode option for developers who hack on the build system.
* The autotools patches came from the older branch, rather than the
newer branch that folded the fixes into the original patches.
* Some merge commits are empty. These would have been better avoided by
using 'git rebase' to stack all of the patches into a linear history.
On the positive side of things:
* x86, x86_64, and ARM pass their regression tests.
--
Zach Welch
CodeSourcery
zwelch at codesourcery.com
(650) 331-3385 x743
More information about the Ltrace-devel
mailing list