[Ltrace-devel] [PATCH] output.c: Fix open_memstream() compilation error

[Petr Machata]

Sedat Dilek <sedat.dilek at gmail.com> writes:

> With the latest ltrace from GIT repository my build on MIPSEL breaks with
> the following error messages:
>
> [ build.log ]
> ...
> output.c: In function 'delim_output':
> output.c:626:3: error: implicit declaration of function 'open_memstream' [-Werror=implicit-function-declaration]
> output.c:626:15: error: initialization makes pointer from integer without a cast [-Werror]
> cc1: all warnings being treated as errors
> make[3]: *** [output.lo] Error 1

I was afraid something like that would pop up, the function is just too
new.  If it works after defining _GNU_SOURCE, then that's great.

I ended up not using your patch, mainly due to the excessive commit
message.  Normally all of it would be under the "---" mark below, and
the commit message would contain just something like "uClibc and eglibc
only define open_memstream when _GNU_SOURCE is defined".

Thanks for digging this out and thanks to Edgar for review.

> ---

(here)

>  output.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/output.c b/output.c
> index 94c433d..1555f2f 100644
> --- a/output.c
> +++ b/output.c
> @@ -24,6 +24,7 @@
>  
>  #include "config.h"
>  
> +#define _GNU_SOURCE /* For open_memstream.  */
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <stdarg.h>

Thanks,
PM