[Ltrace-devel] [PATCH v1 2/6] Allow extension tags in proc_find_dynamic_entry_addr

[Petr Machata]

edgar.iglesias at gmail.com writes:

> From: "Edgar E. Iglesias" <edgar at axis.com>
>
> Remove the check for generic tags allowing the caller
> to pass extension tags. I couldn't find a way to strictly
> validate the tag nr, furthermore the seek tag is internally
> generated so I simply dropped the check (beyond checking for
> positive values).
>
> One way possible could be to check for:
> (tag >= DT_NULL && tag < DT_NUM) || (tag >= DT_LOOS && tag <= DT_HIPROC)
>
> But I'm not sure thats OK.

It's OK.  I don't think we need to be careful about the exact value that
we are looking for, the worst that can happen is that we don't find the
tag.

Thanks,
PM