[Ltrace-devel] [PATCH v1 6/6] mipsel: Add support for CPIC main programs

[Petr Machata]

edgar.iglesias at gmail.com writes:

> +/* Are we in pure CPIC mode (the non-PIC ABI extension)?  */
> +static inline int mips_elf_is_cpic(unsigned int elf_flags)

Function name shoud start a new line.

> +	/* FIXME: for CPIC we should really scan both GOT tables
> +	 * to pick up relocations to external functions. Right now
> +	 * function pointers from the main binary to external functions
> +	 * can't be traced in CPIC mode.  */

Two spaces after period that doesn't denote abbreviation.

Other than these two nits I'm fine with the whole series.  When you fix
them, feel free to merge.

Thanks,
PM