[Ltrace-devel] [PATCH] check return value of unw_get_reg and unw_get_proc_name

[Juan Cespedes]

On Mon, Jan 06, 2014 at 07:28:11PM +0100, Petr Machata wrote:
> It seems better to print out the actual error:
> 
> int err = unw_get_reg(&cursor, UNW_REG_IP, (unw_word_t *) &ip);
> if (err < 0) {
>         fprintf(options.output, " > Error: %s\n", unw_strerror(err));
>         continue;
> }
> 
> About that continue, if this errors out, we never change the
> unwind_depth, nor call unw_step.  I suspect that should end it endless
> loop--doesn't it?

Uh, I don't know, you could be right.  The fact is that I already
pushed that patch, but feel free to undo it.


BTW, would it be ok for you if I add hooks to send all the commits to
the list?

-- 
Juan Cespedes
Debian Developer