[Ltrace-devel] Compilation error with dwarf code

[Petr Machata]

Dima Kogan <lists at dima.secretsauce.net> writes:

> Thierry Fauck ( thierry @ linux.vnet.ibm.com ) <thierry at linux.vnet.ibm.com> writes:
>
>> I also got this message if I don't have the proper libraries
>>
>> In file included from proc.c:39:0:
>> dwarf_prototypes.h:4:30: fatal error: elfutils/libdwfl.h: No such file
>> or directory
>>  #include <elfutils/libdwfl.h>
>
> Hi. I fixed this, and it's committed to my local tree:
>
> https://github.com/dkogan/ltrace/tree/build
>
> I'm not an automake expert, and there may be a better way to do this,
> but it works.

Regarding this:

+AM_CONDITIONAL(HAVE_LIBDW, test x"$enable_elfutils" = xyes)

I already see the following in configure.ac:

if test x"$enable_elfutils" = xyes; then
  libdw_LIBS=-ldw
  AC_SUBST(libdw_LIBS)
  AC_DEFINE([HAVE_LIBDW], [1], [we have elfutils libdw])
fi

Which does the same.

The conditional "+= dwarf_prototypes.h" bits are what I'd do as well, so
fine by me.

Thanks,
PM