[Ltrace-devel] Compilation error with dwarf code

[Thierry Fauck ( thierry @ linux.vnet.ibm.com )]

On 05/14/14 09:35, Dima Kogan wrote:
> Thierry Fauck at linux.vnet.ibm.com <thierry at linux.vnet.ibm.com> writes:
>
>> Also tried with dwarf installed and got testsuite result:
>>
>> Running ./ltrace.torture/ppc-lwarx.exp ...
>> FAIL: atomic_add(.*, 5,.*) in
>> /home/ubuntu/ltrace/testsuite/ltrace.torture/ppc-lwarx.ltrace for 0
>> times, should be 1
>> FAIL: atomic_add(.*, 10,.*) in
>> /home/ubuntu/ltrace/testsuite/ltrace.torture/ppc-lwarx.ltrace for 0
>> times, should be 1
>> FAIL: atomic_add(.*, 15,.*) in
>> /home/ubuntu/ltrace/testsuite/ltrace.torture/ppc-lwarx.ltrace for 0
>> times, should be 1
>>         ===  Summary ===
>>
>> # of expected passes        345
>> # of unexpected failures    3
>> # of unsupported tests        1
> OK.
>
> Are those new failures that didn't happen before my patches went in? I
> suspect this is unrelated to my new code.
>
> dima
>
Hello,
I have checked the output of ppc-lwarx.exp and it is :

ppc-lwarx->__libc_start_main(1, 0x3ffff9ac5748, 0x3ffff9ac5758,
0x3ffff9ac5858 <unfinished ...>
atomic_add(0, 5)                                 = <void>
atomic_add(5, 10)                                = <void>
atomic_add(15, 15)                               = <void>
libc.so.6->__tls_get_addr(0x3fff78fec318, 0x3fff78fea718, 1,
0x3ffff9ac5858) = 0x3fff7901b6d0
+++ exited (status 30) +++

and as source is :     atomic_add(&a, 5);
    atomic_add(&a, 10);
    atomic_add(&a, 15);
    return a;

why do we expect : a different prototype

like atomic_add(.*, 5,.*) as result.

And I checked, I didn't have the problem when I used the tree with last commit:
commit 5da68e9b29fce759fbd8c42130f1a231e2a0aadd
Author: Petr Machata <pmachata at redhat.com>
Date:   Fri Feb 28 12:37:15 2014 +0100

    Add --config to man, drop -X from options.c

So it sounds you have fixed issues in your recent code and for me the test must be corrected ?
Peter, what do you think ?
Thanks

Thierry




-- 
Thierry Fauck (thierry at linux.vnet.ibm.com)