[Ltrace-devel] [PATCH 2/6] Make sure there's at least one space after "typedef" when parsing

Роман Донченко dpb at corrigendum.ru
Mon Apr 20 18:15:16 UTC 2015


Petr Machata <pmachata at redhat.com> писал(а) в своём письме Mon, 20 Apr  
2015 10:49:22 +0300:

> Роман Донченко <dpb at corrigendum.ru> writes:
>
>> -	if (strncmp(str, "typedef", 7) == 0) {
>> +	if (strncmp(str, "typedef ", 8) == 0) {
>
> Agreed, the test is wrong.  The new test however disallows "typedef"
> followed by a tab character.  It would be better fixed by dispatching to
> try_parse_kwd.

For the record, I thought this was okay, because eat_spaces doesn't  
recognize tabs either. You might want to fix that, too.



More information about the Ltrace-devel mailing list