[Ltrace-devel] [PATCH] dict entries lost due to erase

Petr Machata pmachata at redhat.com
Wed Jan 7 00:51:07 UTC 2015


Faraz Shahbazker <faraz.shahbazker at imgtec.com> writes:

> I have observed random failures with PIC, when looking up
> breakpoints. It looks like find_slot() doesn't search far enough in to
> the dictionary before giving up, after an item has been erased.
>
> Patch enclosed with a simple test-case.

Thanks.  I think most of ltrace still assumes that erase isn't actually
available, so this never came up.

I decided to go with a different fix, because the continue would skip
over the check for loops that's next.  I took your test case
though--thanks for that.  I applied the test case under your name even
though I touched your patch, so speak up if you are uncomfortable what I
ended up committing.

Thanks,
Petr



More information about the Ltrace-devel mailing list