[Net-ssleay-devel] Re: [patch] Net_SSLeay.pm

[Mike McCauley]

Hi Stas,

Thanks for your patch.
I have now rolled it in, and also improved the -windows flag (it autoguesses 
based on $^O so prob never neeeded now) and added common windows openssl 
paths to search (eg for shining light openssl etc)

I have also added the -path option you suggested.
Now available in the latest SVN

BTW, perhaps you will post to net-ssleay-devel at lists.alioth.debian.org next 
time so others can see whats happening.

Cheers.

On Wednesday 01 March 2006 07:04, Stas Bekman wrote:
> Hi Mike and Florian,
>
> I've attached below a patch that implements a cleaner implementation of
> the openssl path search, which doesn't clobber the previous values. It
> also unbreaks the build process under CPAN and other shells, which don't
> prepend -- before sending extra arguments (but breaks the existing
> option). At the moment it's impossible to make this module build if you
> have things like PREFIX passed to CPAN shell.
>
> May I suggest that instead of expecting the optional path to openssl as a
> last argument before --, you instead use a key, in which case everybody
> will be happier, e.g:
>
> ./Makefile.PL [-windows] [-rsaref] [-m|-t|-d] [-g] [-path=OpenSSL install
> path] [-- args]
>
> ========
>
> I've also noticed that the docs aren't up-to-date, as it goes:
>
>    SSLeay.pm:This man page documents version 1.24, released on 18.8.2003.
>
> perhaps removing that line completely will prevent this situation in the
> future.
>
> ========
>
> Thanks!
>
> --- Net_SSLeay.pm-1.30/Makefile.PL.orig	2006-02-28 11:27:15.000000000 -0800
> +++ Net_SSLeay.pm-1.30/Makefile.PL	2006-02-28 12:49:18.000000000 -0800
> @@ -19,8 +19,8 @@
>              -g         Compile for debugging (see README)
>              -rsaref    provides support for linking against rsaref
>              -windows   sets library paths for windows build
> -           --         Introduces arguments for Make::Maker. Typically used
> -                      to pass PREFIX=/path/to/your/perl/libs
> +           --         Introduces arguments for ExtUtils::MakeMaker.
> Typically +                      used to pass
> PREFIX=/path/to/your/perl/libs E.g:   ./Makefile.PL -d
>          ./Makefile.PL -t /apps/openssl/std -- PREFIX=/home/koerkki/perllib
>
> @@ -41,12 +41,23 @@
>   $optimize = shift if $ARGV[0] eq '-g';
>
>   # It seems at least Redhat installs OpenSSL in /usr ...
> -$openssl_path = '/usr' if -x '/usr/bin/openssl' || -x '/usr/sbin/openssl';
> -$openssl_path = '/opt/ssl' if -x '/opt/ssl/bin/openssl'
> -    || -x '/opt/ssl/sbin/openssl';
> -$openssl_path = '/usr/local/ssl' if -x '/usr/local/ssl/bin/openssl';
> -$openssl_path = '/apps/openssl/std' if -x '/apps/openssl/std/bin/openssl';
> -$openssl_path = shift if @ARGV && $ARGV[0] ne '--';
> +my %search =
> +    (
> +     '/usr/bin/openssl'              => '/usr',
> +     '/usr/sbin/openssl'             => '/usr',
> +     '/opt/ssl/bin/openssl'          => '/opt/ssl',
> +     '/opt/ssl/sbin/openssl'         => '/opt/ssl',
> +     '/usr/local/ssl/bin/openssl'    => '/usr/local/ssl',
> +     '/apps/openssl/std/bin/openssl' => '/apps/openssl/std',
> +);
> +
> +my $openssl_path = '';
> +while (my($k, $v) = each %search) {
> +    if (-x $k) {
> +        $openssl_path = $v;
> +        last;
> +    }
> +}
>
>   shift if $ARGV[0] eq '--';   # Rest of args are for MakeMaker

-- 
Mike McCauley                               mikem at open.com.au
Open System Consultants Pty. Ltd            Unix, Perl, Motif, C++, WWW
9 Bulbul Place Currumbin Waters QLD 4223 Australia   http://www.open.com.au
Phone +61 7 5598-7474                       Fax   +61 7 5598-7070

Radiator: the most portable, flexible and configurable RADIUS server 
anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, 
Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, 
TTLS, PEAP etc on Unix, Windows, MacOS, NetWare etc.