[Net-ssleay-devel] Latest development

[Florian Ragwitz]

Hello,

I did some net-ssleay development recently. I'd like you to do some
review. If everything is fine in your eyes I'd like to do a development
release to cpan as 1.31_01. Is that fine with you?

I also have some questions:

ERR_error_string's signature currently looks like that:

  char*
  ERR_error_string(error,buf=NULL)

This doesn't make much sense to me. Usually it's called as:

  $err_str = ERR_error_string($error);

But the prototype allows to do something like:

  ERR_error_string($error, $err_str);

which stores the error string into $err_str, at least as long as the
value previously stored in $err_str is at least as long as the error
string openssl is going to make out of $error. This isn't a too perlish
interface. I suggest changing the signature to:

  char*
  ERR_error_string(error)

and pass NULL as the second argument to the C function in any case. What
do you think?


Also there is SSL_callback_ctrl and SSL_CTX_callback_ctrl. This
functions (on the c level) take callbacks, but the perl signatures in
SSLeay.xs look like that:

  typedef void callback_no_ret();

  long
  SSL_callback_ctrl(ssl,i,fp)
    SSL* ssl
    int i
    callback_no_ret* fp

This is not going to work for obvious reasons. We could either make it
work or completly remove those functions as the openssl docs say:

  These functions should never be called directly.

So as they a) don't work ATM and b) they're not intended to be used
directly, I'd suggest to remove them.


Thanks for your thoughts,
Flo

-- 
BOFH excuse #244:
Your cat tried to eat the mouse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/net-ssleay-devel/attachments/20060915/7cf2f9e9/attachment.pgp