[Neurodebian-devel] python-expyriment uploaded to mentors.debian.net

Yaroslav Halchenko debian at onerussian.com
Wed Mar 26 01:46:45 UTC 2014 

Hi Oliver,

Great to see big progress -- almost there!

1. note that 0.7.0~0a6550d  sorts before 0.7.0 (which you provided before)
due to special meaning of ~.  Unlike '+' it signals that it is "preceeding"
thing (so now entries in changelog go 'backwards' and -2 revision is
"unwarranted").

1.1 ideally there should be an ITP bug report which would state the
intent for packaging expyriment... I have filed it for you, so please
use (Closes: #742639) in your changelog entry

Please just remove previous changelog entry, or mark it as UNRELEASED
(not unstable where it didn't get into yet).  That closes statement
should be in the latest changelog (that is the one we would upload to
Debian and it would close that bug report upon acceptance)

2. (just to keep in mind) treeish (shasums) simply could not be sorted,
happen you later on decide to make package of another snapshot release

I usually use output of 'git describe' output to give me the pkg
version, e.g.

git describe --tags --match v0.7.0 0a6550d
v0.7.0-12-g0a6550d

NB1 --tags in this case because existing ones are not "proper" ones, should be annotated or signed
NB2 --match so just to avoid  that -debian one ;)

this would tell me to make an "upstream" version

0.7.0+git12-g0a6550d

with Debian revision -1 (because it is the first revision of this upstream version)
making it altogether 0.7.0+git12-g0a6550d-1


3. it does fail to build for me as well:

./create_rst_api_reference.py
Expyriment 0.7.0 (Revision 0a6550d; Python 2.7.6)
File: create_rst_api_reference.py (9012cc)
Traceback (most recent call last):
  File "./create_rst_api_reference.py", line 9, in <module>
    import expyriment
  File "/tmp/buildd/python-expyriment-0.7.0~0a6550d/documentation/sphinx/expyriment/__init__.py", line 154, in <module>
    "\nPlease install Pygame 1.9.")
ImportError: Expyriment 0.7.0 needs the package 'Pygame').
Please install Pygame 1.9.
make[3]: *** [expyriment.rst] Error 1
make[3]: Leaving directory `/tmp/buildd/python-expyriment-0.7.0~0a6550d/documentation/sphinx'
make[2]: *** [rst] Error 2
make[2]: Leaving directory `/tmp/buildd/python-expyriment-0.7.0~0a6550d/documentation/sphinx'
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory `/tmp/buildd/python-expyriment-0.7.0~0a6550d'
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2


as you are informing here because pygame is not installed... add python-pygame to Build-Depends.

btw I did

sudo nd_build4debianmain *dsc --hookdir=$HOME/neurodebian/tools/hooks

to enter into that clean environment upon failure to build, so I could figure
out what else is missing from build-depends.  Seems to be nothing else
missing

4.  sources should be 'rebuildable', but atm subsequent

dpkg-buildpackage -uc -us -rfakeroot   results in

...
 dpkg-source -b python-expyriment-0.7.0~0a6550d
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building python-expyriment using existing ./python-expyriment_0.7.0~0a6550d.orig.tar.gz
dpkg-source: error: cannot represent change to python-expyriment-0.7.0~0a6550d/documentation/sphinx/expyriment:
dpkg-source: error:   new version is symlink to ../../expyriment/
dpkg-source: error:   old version is nonexistent
dpkg-source: warning: executable mode 0755 of 'bin/expyriment' will not be represented in diff
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b python-expyriment-0.7.0~0a6550d gave error exit status 2

so added 'rm -f documentation/sphinx/expyriment' and 'rm -rf bin' to
override_dh_clean of debian/rules

5. looking at lintian over the binary package:

> lintian python-expyriment_0.7.0~0a6550d-2_amd64.changes
W: python-expyriment: wrong-name-for-upstream-changelog usr/share/doc/python-expyriment/CHANGES.md.gz

don't give it to .docs -- see dh_installchangelogs

W: python-expyriment: latest-debian-changelog-entry-without-new-version

that is the version downgrade issue  I was  blurbing about

W: python-expyriment: wrong-section-according-to-package-name python-expyriment => python

it is funny that way... I just usually follow the advice usually ;-)
but we could override this one 

W: python-expyriment: embedded-javascript-library usr/share/doc/python-expyriment/html/_static/jquery.js
W: python-expyriment: embedded-javascript-library usr/share/doc/python-expyriment/html/_static/underscore.js

ideally should be replaced with symlinks (and corresponding depends) to
the ones provided by libjs-sphinxdoc package

W: python-expyriment: binary-without-manpage usr/bin/expyriment

since there is basic --help output, you could address this by autogenerating
manpage (and craft some description etc for it) using help2man.  It would help
uses -- what is the purpose of that script etc... ?

summary:

So -- please straighten out versioning, add Closes:, add missing build-depend,
address above lintian warnings, make sure again it does build in a clean
environment (either using nd tools or just pbuilder), and we should be
all set ;)

Cheers!

On Tue, 25 Mar 2014, Oliver Lindemann wrote:

>    Dear Yaroslav,

>    I think I accommodated all your points and uploaded a new package to
>    mentors. Please let me known if there is anything missing.

>    I also tried to build the packages with ndtools, but it didn't work for
>    some reasons. I merely got a summary.build log file with a very unspecific
>    failure message. I am sure that you can figure out quickly what the
>    problem is.

>    Source package:   
>    [1]http://mentors.debian.net/debian/pool/main/p/python-expyriment/python-expyriment_0.7.0~0a6550d-2.dsc

>    Oliver

>    On 04/03/2014 15:01, Yaroslav Halchenko wrote:

>  Hi Oliver,

>  Great to hear from you with expyriment source package.

>  We would be happy to review/sponsor it ... quick feedback to get the
>  ball rolling:

>  1. There seemed to be a slight hiccup with uploads
>  $ dget [2]http://mentors.debian.net/debian/pool/main/p/python-expyriment/python-expyriment_0.7.0-2.dsc
>  dget: retrieving [3]http://mentors.debian.net/debian/pool/main/p/python-expyriment/python-expyriment_0.7.0-2.dsc
>    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                   Dload  Upload   Total   Spent    Left  Speed
>  100  1454  100  1454    0     0   7005      0 --:--:-- --:--:-- --:--:-- 14116
>  dget: retrieving [4]http://mentors.debian.net/debian/pool/main/p/python-expyriment/python-expyriment_0.7.0.orig.tar.gz
>    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                   Dload  Upload   Total   Spent    Left  Speed
>  100 1995k  100 1995k    0     0   894k      0  0:00:02  0:00:02 --:--:--  938k
>  dget: retrieving [5]http://mentors.debian.net/debian/pool/main/p/python-expyriment/python-expyriment_0.7.0-2.diff.gz
>    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                   Dload  Upload   Total   Spent    Left  Speed
>  100  1219  100  1219    0     0   5868      0 --:--:-- --:--:-- --:--:-- 11834
>  python-expyriment_0.7.0-2.dsc:
>        Good signature found
>     validating python-expyriment_0.7.0.orig.tar.gz
>  dscverify: invalid file length for python-expyriment_0.7.0.orig.tar.gz (wanted 2045454 got 2042893)
>     validating python-expyriment_0.7.0-2.diff.gz
>  Validation FAILED!!


>  could you please verify that correct "version" reaches mentors?

>  2. Ideally all previous debian versions which haven't reached Debian proper
>  would be marked as UNRELEASED (not unstable).

>  3. there should be no pre-generated documentation under documentation/ --
>  only sphinx sources, and the rest built at package build time

>  4.  I would recomment to use 3.0 (quilt) source format, which would have
>  .debian.tar.gz instead of .diff.gz , e.g.

>  (git)novo:~exppsy/pandas[debian]
>  $> cat debian/source/format
>  3.0 (quilt)

>  5. debian/copyright

>  checkout the current  standard for it -- tiny changes needed:
>  [6]http://www.debian.org/doc/packaging-manuals/copyright-format/1.0

>  6. ./documentation/sphinx/Testsuite.rst describes present tests... it would be
>  really nice if some of those (testing presence of fonts etc) sensible to run
>  under xvfb were excercised.  I have done the same for psychopy and
>  psychtoolbox-3.   you could check those packages for xvfb setup/dependencies to add.

>  7. it would be really nice if you could have followed
>  [7]http://neuro.debian.net/blog/2012/2012-04-14_ndtools.html
>  and tested package building across multiple debian/ubuntu releases.

>  8. debian/control -- no need for "A " in short description -- it is assumed ;)

>  also "open-source and platform independent" another not needed -- if it
>  is in Debian, it is open-source,  platform independent - since you are on
>  Debian already, it is kinda irrelevant

>  also if you could provide Vcs- fields -- would be nice


>  Cheers!

>  On Mon, 03 Mar 2014, Oliver Lindemann wrote:


>     Hi,


>     we have recently release a new version of Expyriment, a light-weight
>     Python library for the script-based development of experiments
>     ([1][8]http://docs.expyriment.org). It might be interesting to you to include
>     Expyriment to the NeuroDebian repro. Please find all details about the
>     package at mentors.debian.net.
>     [2][9]http://mentors.debian.net/package/python-expyriment


>     Best,
>     Oliver Lindemann


>     On 03/03/2014 18:21, mentors.debian.net wrote:


>   Hi.


>   Your upload of the package 'python-expyriment' to mentors.debian.net was
>   successful. Others can now see it. The URL of your package is:
>   [3][10]http://mentors.debian.net/package/python-expyriment


>   The respective dsc file can be found at:
>   [4][11]http://mentors.debian.net/debian/pool/main/p/python-expyriment/python-expyriment_0.7.0-1.dsc


>   If you do not yet have a sponsor for your package you may want to go to
>   [5][12]http://mentors.debian.net/sponsors/rfs-howto/python-expyriment
>   and set the "Seeking a sponsor" option to highlight your package on the
>   welcome page.


>   You can also send an RFS (request for sponsorship) to the debian-mentors
>   mailing list. Your package page will give your suggestions on how to
>   send that mail.


>   Good luck in finding a sponsor!


>   Thanks,
-- 
Yaroslav O. Halchenko, Ph.D.
http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org
Senior Research Associate,     Psychological and Brain Sciences Dept.
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik

More information about the Neurodebian-devel mailing list