From enrico at enricozini.org  Thu Sep 12 11:42:40 2013
From: enrico at enricozini.org (Enrico Zini)
Date: Thu, 12 Sep 2013 13:42:40 +0200
Subject: [newmaint-site] Some patches proposal
In-Reply-To: <87d2olv9tk.fsf@gmail.com>
References: <87d2olv9tk.fsf@gmail.com>
Message-ID: <20130912114240.GA2544@enricozini.org>

On Sat, Sep 07, 2013 at 12:56:07AM +0200, Marco Bardelli wrote:

> I propose two patches for:
> 
> * Migrate restricted/views.py:advocate_as_dd to use the new
>   backend.email.send_notification, considering that the Log entry with
>   the advocacy is changed_by the advocate, so it contains all needed
>   information to send the mail to debian-newmaint.
> 
> http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=d81d387a3d1e09f3d20007a89dcb68850889b918
> (templates needs review)
> 
> * When impersonating other people, log entries should be prefixed by a
>   tag like [enrico as ganneff], so that work is credited to the right
>   person
> 
> http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=d1ca270183f2f8b2c1fe9769fc39ce24e3b7ad09

Thanks! A couple of comments:

> --- a/restricted/templates/restricted/advocate-dd.html
> +++ b/restricted/templates/restricted/advocate-dd.html
> @@ -66,6 +66,10 @@
>      </tr>
>  {% endif %}
>      <tr>
> +        <th>{{form.is_public.label_tag}}:</th>
> +        <td>{{form.is_public}} {{form.is_public.errors}}</td>
> +    </tr>
> +    <tr>
>          <th>{{form.logtext.label_tag}}:</th>
>          <td>{{form.logtext}} {{form.logtext.errors}}</td>
>      </tr>

Advocacy messages are public by default, and the form makes it explicit:

  An email with your advocacy message will be sent to the
  <a href="http://lists.debian.org/debian-newmaint">debian-newmaint</a>
  <em>public</em> mailing list</li>

Can you remove the is_public field from the form, and just save the log
entry with is_public=True?


The other is in:

> +++ b/templates/notification_mails/advocacy_as_dd.txt
> @@ -0,0 +1,14 @@
> +{% load nm %}
> +From: {{ log.changed_by.fullname }} via nm <{{ log.changed_by.email }}>

It should be "{{ log.changed_by.preferred_email }}" instead, so the from
will thave the @debian.org addresses. Besides that, the template looks
good.


I look forward to pulling and deploying the lot.


Ciao,

Enrico

-- 
GPG key: 4096R/E7AD5568 2009-05-08 Enrico Zini <enrico at enricozini.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/newmaint-site/attachments/20130912/dc6e7d26/attachment.sig>

From bardelli.marco at gmail.com  Thu Sep 12 20:29:02 2013
From: bardelli.marco at gmail.com (Marco Bardelli)
Date: Thu, 12 Sep 2013 22:29:02 +0200
Subject: [newmaint-site] Some patches proposal
In-Reply-To: <20130912114240.GA2544@enricozini.org> (Enrico Zini's message of
 "Thu, 12 Sep 2013 13:42:40 +0200")
References: <87d2olv9tk.fsf@gmail.com> <20130912114240.GA2544@enricozini.org>
Message-ID: <87ob7x238x.fsf@gmail.com>

Enrico Zini <enrico at enricozini.org> writes:

> On Sat, Sep 07, 2013 at 12:56:07AM +0200, Marco Bardelli wrote:
>
>>[... skip ...]
>
> Thanks! A couple of comments:
Thanks to you.
>
>> --- a/restricted/templates/restricted/advocate-dd.html
>> +++ b/restricted/templates/restricted/advocate-dd.html
>> @@ -66,6 +66,10 @@
>>      </tr>
>>  {% endif %}
>>      <tr>
>> +        <th>{{form.is_public.label_tag}}:</th>
>> +        <td>{{form.is_public}} {{form.is_public.errors}}</td>
>> +    </tr>
>> +    <tr>
>>          <th>{{form.logtext.label_tag}}:</th>
>>          <td>{{form.logtext}} {{form.logtext.errors}}</td>
>>      </tr>
>
> Advocacy messages are public by default, and the form makes it explicit:
>
>   An email with your advocacy message will be sent to the
>   <a href="http://lists.debian.org/debian-newmaint">debian-newmaint</a>
>   <em>public</em> mailing list</li>
>
> Can you remove the is_public field from the form, and just save the log
> entry with is_public=True?
>
>
> The other is in:
>
>> +++ b/templates/notification_mails/advocacy_as_dd.txt
>> @@ -0,0 +1,14 @@
>> +{% load nm %}
>> +From: {{ log.changed_by.fullname }} via nm <{{ log.changed_by.email }}>
>
> It should be "{{ log.changed_by.preferred_email }}" instead, so the from
> will thave the @debian.org addresses. Besides that, the template looks
> good.

I fixed both issues in a "re-new rebased" commit at:
http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=3f757d36e00feb378a57cd790d79681ffb566309

Probably this commit could be cherry-picked only after the previous one for
impersonating issue at:
http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=c4e432364f23c26bd1413bd1c7cab7203b3cd7e1

>
>
> I look forward to pulling and deploying the lot.
>
both commits are on my personal branch emails_advocate_as_dd.

I'm thinking to work on:
* Allow advocates to edit personal information of people in active
  processes advocated by them

soon for news.

>
> Ciao,
> Enrico
Ciao,
Marco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/newmaint-site/attachments/20130912/0a2b1975/attachment.sig>

From bardelli.marco at gmail.com  Fri Sep 13 00:21:39 2013
From: bardelli.marco at gmail.com (Marco Bardelli)
Date: Fri, 13 Sep 2013 02:21:39 +0200
Subject: [newmaint-site] Allow advocates to edit personal information
Message-ID: <87k3il1sh8.fsf@gmail.com>


Hi list,

i scratched a patch for issue:
* Allow advocates to edit personal information of people in active
  processes advocated by them

available at:
http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=e34cbe49916d1c475fd5e0bf690d6ae35ec7dd56

I'm a bit confused about 'can_be_edited' properties for Person and
Process models, why if the am is None we allow editing ??

anyway, the stuff seems ok.

Regards,
Marco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/newmaint-site/attachments/20130913/1a276f53/attachment.sig>

From enrico at enricozini.org  Fri Sep 13 17:40:27 2013
From: enrico at enricozini.org (Enrico Zini)
Date: Fri, 13 Sep 2013 19:40:27 +0200
Subject: [newmaint-site] Some patches proposal
In-Reply-To: <87ob7x238x.fsf@gmail.com>
References: <87d2olv9tk.fsf@gmail.com> <20130912114240.GA2544@enricozini.org>
 <87ob7x238x.fsf@gmail.com>
Message-ID: <20130913174027.GA6357@enricozini.org>

On Thu, Sep 12, 2013 at 10:29:02PM +0200, Marco Bardelli wrote:

> > I look forward to pulling and deploying the lot.
> both commits are on my personal branch emails_advocate_as_dd.

Thanks, it's deployed now.


Ciao,

Enrico

-- 
GPG key: 4096R/E7AD5568 2009-05-08 Enrico Zini <enrico at enricozini.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/newmaint-site/attachments/20130913/0e7f7596/attachment.sig>

From enrico at enricozini.org  Sat Sep 14 18:15:33 2013
From: enrico at enricozini.org (Enrico Zini)
Date: Sat, 14 Sep 2013 20:15:33 +0200
Subject: [newmaint-site] Allow advocates to edit personal information
In-Reply-To: <87k3il1sh8.fsf@gmail.com>
References: <87k3il1sh8.fsf@gmail.com>
Message-ID: <20130914181533.GA32755@enricozini.org>

On Fri, Sep 13, 2013 at 02:21:39AM +0200, Marco Bardelli wrote:

> available at:
> http://anonscm.debian.org/gitweb/?p=users/safanaj-guest/nm2.git;a=commitdiff;h=e34cbe49916d1c475fd5e0bf690d6ae35ec7dd56
> 
> I'm a bit confused about 'can_be_edited' properties for Person and
> Process models, why if the am is None we allow editing ??

Now I recall. Without the AM, checks if the record can generally be
edited: it cannot, for example, if there is an account in LDAP, because
LDAP is now the master record for it. With the AM, it checks if it can
be edited by a specific person.

It's a method that I overloaded badly. Luckily it's only used in 3
places in the whole codebase, and always with an 'am' argument passed.

The method also doesn't really specify well what can be edited:

  For a Person:
   - the bio can always be edited, by FD, the AM, advocates and even
     the applicant, and at any time, since we hold the original version.
   - cn,mn,sn,email,fpr can be edited by FD, the AM, advocates and even
     the applicant only as long as there is no LDAP record, and also
     only before the record is in FD or DAM's hands, since by then we're
     doing consistency checks of the lot and preparing tickets to be
     filed to keyring-maint and DSA for the account to get created.
   - fd_comment can only be edited by FD, but at any time
   - status can only be edited by DAM (well, currently also FD, but we
     trust that they won't edit it)

  For a Process:
   - progress can be edited by FD, and in some cases the AM. The rest
     cannot be changed, or can only be changed via specific views, like
     adding advocates.

I've refactored the methods related to permissions into something more
appropriately fine grained. The old can_be_edited methods are removed,
and there are now 'permissions_of' methods in Person and Process to
compute a NMPermissions object which tells all there is to know.

I pushed it to master and deployed it. As a side effect, now for most of
the process, advocates can edit the applicant's information as if they
were the AMs.


Ciao,

Enrico

-- 
GPG key: 4096R/E7AD5568 2009-05-08 Enrico Zini <enrico at enricozini.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/newmaint-site/attachments/20130914/5b769f18/attachment.sig>

From enrico at enricozini.org  Sun Sep 15 15:45:44 2013
From: enrico at enricozini.org (Enrico Zini)
Date: Sun, 15 Sep 2013 17:45:44 +0200
Subject: [newmaint-site] Re-deployed DC site
Message-ID: <20130915154543.GA2026@enricozini.org>

Hello,

thanks to Zobel, from this morning we have a proper postgresql database
for the DC site. I took advantage of having to redeploy to simplify the
CD model even further and clean up things a bit.

I've dropped the Person table, now Identifiers just link to Django's
User. There is a user profile with extra info we may want to save in the
future.

An Identifier has an optional link to User. Identifiers without the link
are unclaimed and will not be shown publicly: this should make us
opt-in.

I hope we'll be ok with Django's short User.username field: we'll see it
as we'll see how people can log in. In the meantime, we have south
migrations enabled.

The list is still empty: next in the todo list is an interface to add
new sources, and public POST interface for submitting data.

I put up a workable TODO list here:
https://wiki.debian.org/Teams/FrontDesk/DcSiteDevel
it's still very small, because we still don't have data and I'd like to
think a bit more about how to authenticate people, but it will come.

In the meantime, feel free to work on those items that are there.


Ciao,

Enrico

-- 
GPG key: 4096R/E7AD5568 2009-05-08 Enrico Zini <enrico at enricozini.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/newmaint-site/attachments/20130915/6571042c/attachment.sig>