[nut-Patches][312346] megatec patch for effecta MH700

[nut-patches at alioth.debian.org]

Patches item #312346, was changed at 2010-02-12 12:37 by Arjen de Korte
You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=411544&aid=312346&group_id=30602

Status: Closed
Priority: 3
Submitted By: Armin Diehl (ard-guest)
Assigned to: Arjen de Korte (adkorte-guest)
Summary: megatec patch for effecta MH700 
Category: None
Group: None
Resolution: Rejected


Initial Comment:
simple patch to add support for Effecta MH700, only adds one entry to the list of known battery types



----------------------------------------------------------------------

>Comment By: Arjen de Korte (adkorte-guest)
Date: 2010-02-14 23:53

Message:
I stand corrected, you're probably right. Nevertheless I'll reject it anyway. The megatec driver is no longer maintained and is scheduled for removal so we no longer accept patches for it. Please switch to the blazer_ser driver instead.

----------------------------------------------------------------------

Comment By: Armin Diehl (ard-guest)
Date: 2010-02-14 22:00

Message:
Why shuold the patch break detection ?
set_battery_params searches for nominal first (24 V in my case). If a match was found it checks volt_now against min and max in the table.
I added 24V with min=1.5 and max=3, the only other existing entry with nominal=24V has min=18 and max=30, so no overlapping.



----------------------------------------------------------------------

Comment By: Arjen de Korte (adkorte-guest)
Date: 2010-02-12 15:25

Message:
This patch breaks the detection for already existing devices. Use'battvoltmult' instead to correct the voltage readings (or better yet, upgrade to the 'blazer_(ser|usb)' driver instead).

----------------------------------------------------------------------

You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=411544&aid=312346&group_id=30602