[PKG-OpenRC-Debian] Bug#874790: /lib/rc/bin/lsb2rcconf: Boot dependency does not work for nfs-common

[Benda Xu]

Thanks Adam,

Adam Borowski <kilobyte at angband.pl> writes:

> On Sun, Nov 19, 2017 at 10:46:12PM +0900, Benda Xu wrote:
>> Do you have a quick idea of parsing /etc/insserv.conf.d/* along with
>> /etc/insserv.conf in lsb2rcconf?
>
> I've looked at it before, but somehow I got distracted and didn't mark this
> on my TODO.  The way real insserv parses file names is _thoroughly_ insane:
> details are in this bug report (https://bugs.debian.org/874790).  Looking at
> all current users in Debian, I'd suggest filtering files in
> /etc/insserv.conf.d/* by /^[a-zA-Z0-9_-]+$/ rather than copying insserv
> exactly.  This should be safe enough for expected out-of-archive uses.
>
> Also, affected daemons look significant enough (rpcbind (NFS), postfix,
> mariadb, unbound, ...) that I believe this bug should be bumped to at least
> severity:important and fixed in stable.
>
> (Well, unbound works for me, but NFS is broken.)

I have read your dissection of insserv and I think /^[a-zA-Z0-9_-]+$/ is
a good choice.  It looks like the glibc regex_t is good to go,

  https://www.gnu.org/software/libc/manual/html_node/Regular-Expressions.html

Just want to see what Demitry thinks and if he would like to integrate
it into lsb2rcconf.

Cheeers,
Benda