[Openstack-devel] Bug#712971: Bug#712971: New upstream release

[Thomas Goirand]

On 07/13/2013 10:27 PM, Wouter Bolsterlee wrote:
> Hi,
> 
> You're using "git archive" to make a tarball:
> 
> Thomas Goirand schreef op za 13-07-2013 om 22:07 [+0800]:
>> git archive --prefix=$(DEBPKGNAME)-$(GIT_TAG)/ $(GIT_TAG) \
>>         | xz >../$(DEBPKGNAME)_$(VERSION).orig.tar.xz ;
> 
> ...but that is not how Python packages for release on PyPI are made.
> 
>> In what way the release tarball differ from the source on github?
> 
> The release tarball is made using "python setup.py sdist", which gathers
> metadata and includes relevant files in a tarball, in such a way that
> tools like pip can later "pip install $PACKAGE-$VERSION.tar.gz". The
> included files may or may not match what is kept in version control,
> e.g. a tarball may contain generated files not kept in version control.

What the packaging does is "python setup.py install". If your source
code doesn't install things correctly using this command, then you have
a serious problem.

> An illustrative example would be my Plyvel project (which is not related
> to HappyBase in any way). The released tarballs contain C and C++ code
> generated by Cython, while only the Cython sources are under version
> control.

Well, if Plyvel doesn't install things correctly using "python setup.py
build" then "python setup.py install", then it isn't designed correctly
and should be fixed IMO.

Thomas