[PKG-Openstack-devel] Bug#780860: upgrade uncomments config file setting volume_group

[Gaudenz Steinlin]

Package: cinder-common
Version: 2014.1.3-11
Severity: important

Upgrading from 2014.1.3-7 to 2014.1.3-11 leads to the following config file change:

diff -ur openstack-pre-upgrade/cinder/cinder.conf openstack-post-upgrade/cinder/cinder.conf
--- openstack-pre-upgrade/cinder/cinder.conf    2015-03-19 12:38:14.030990864 +0100
+++ openstack-post-upgrade/cinder/cinder.conf   2015-03-20 15:34:01.787252473 +0100
@@ -1277,7 +1277,7 @@
 
 # Name for the VG that will contain exported volumes (string
 # value)
-#volume_group=cinder-volumes
+volume_group = cinder-volumes
 
 # If set, create lvms with multiple mirrors. Note that this
 # requires lvm_mirrors + 2 pvs with available space (integer

I debugged this a bit and it seems that "pkgos_inifile get" also reads commented 
out configuration directives and does not return NOT_FOUND. Because of this
the commented out setting is saved into the debconf database by the config script.
The postinst script then changes the config file to match the debconf setting.

This does not happen on first installation because when the config script is run,
the cinder.conf file does not yet exist.

I report this bug on cinder-common because I first experienced it with this package,
but there might similar bugs with other OpenStack packages that use pkgos_inifile in
the same way. Probably this should be fixed in openstack-pkg-tools. Feel free to reassing
if you agree.

Also this is borderline to RC severity because it changes a configuration file. If you see
a chance to get this fixed before the release, please upgrade the bug severity. But I don't
want cinder to be removed from jessie because of this.

Gaudenz


-- System Information:
Debian Release: 8.0
  APT prefers testing-proposed-updates
  APT policy: (500, 'testing-proposed-updates'), (500, 'testing'), (100, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)