[PKG-Openstack-devel] Too restrictive dependencies in python-hacking

[Thomas Goirand]

Hi Clint,

In python-hacking, I can see you're the author of too restrictive
dependencies. I saw stuff like this:

Build-Depends: python-pbr (>= 0.6),
               python-pbr (<< 1.0),
Build-Depends-Indep: python-sphinx (>= 1.2.1),
                     python-sphinx (<< 1.3),

First, you have to know that what is written in OpenStack requirements
should *not* be followed blindly. What's there is to inform the *gate*,
not package maintainers. In this particular case, there's no reason to
restrict the PBR version upper bound, version higher than 1.0 are very
fine. Same for python-sphinx, and that last one is now an RC bug (ie:
#799312) which I'm fixing right now.

Also, you do not need to do >= 0.6 for PBR, as this version is already
satisfied in Jessie. Same with python-sphinx. And as sphinx is needed
during the clean target, it should go in Build-Depends, not in
Build-Depends-Indep.

There's no need to explicitly depend on the Python 2.7 version of
subunit or testrepository (the subunit package depends on
python-subunit, and testrepository depends on python-testrepository and
python3-testrepository, you only need explicit python3-subunit if you
want to do py3 tests).

So finally, the correct way to write things is this:

Build-Depends: debhelper (>= 9),
               openstack-pkg-tools,
               python-all,
               python-pbr,
               python-setuptools,
               python-sphinx,
               python3-all,
               python3-pbr,
               python3-setptools,
Build-Depends-Indep: pyflakes,
                     python-coverage,
                     python-fixtures,
                     python-flake8,
                     python-oslosphinx,
                     python-testscenarios,
                     python-testtools,
                     subunit,
                     testrepository,

I thought you'd like to know. I also fixed the runtime Depends:.

Cheers,

Thomas Goirand (zigo)