[PKG-Openstack-devel] Bug#840035: Bug#840035: websockify: FTBFS on non-Linux: TCP_KEEPCNT unusable

[Thomas Goirand]

On 10/07/2016 09:41 PM, Aaron M. Ucko wrote:
> Source: websockify
> Version: 0.8.0+dfsg1-3
> Severity: important
> Justification: fails to build from source (but built successfully in the past)
> 
> Builds of websockify for kFreeBSD and the Hurd have been failing;
> kFreeBSD builds fail with
> 
>   ======================================================================
>   ERROR: test_socket_set_keepalive_options (test_websocket.WebSocketServerTestCase)
>   ----------------------------------------------------------------------
>   Traceback (most recent call last):
>     File "/«BUILDDIR»/websockify-0.8.0+dfsg1/tests/test_websocket.py", line 325, in test_socket_set_keepalive_options
>       tcp_keepintvl=keepintvl)
>     File "/«BUILDDIR»/websockify-0.8.0+dfsg1/websockify/websocket.py", line 726, in socket
>       sock.setsockopt(socket.SOL_TCP, socket.TCP_KEEPCNT,
>   AttributeError: 'module' object has no attribute 'TCP_KEEPCNT'
> 
> and Hurd builds fail with
> 
>   ======================================================================
>   ERROR: test_socket_set_keepalive_options (test_websocket.WebSocketServerTestCase)
>   ----------------------------------------------------------------------
>   Traceback (most recent call last):
>     File "/<<BUILDDIR>>/websockify-0.8.0+dfsg1/tests/test_websocket.py", line 325, in test_socket_set_keepalive_options
>       tcp_keepintvl=keepintvl)
>     File "/<<BUILDDIR>>/websockify-0.8.0+dfsg1/websockify/websocket.py", line 727, in socket
>       tcp_keepcnt)
>     File "/usr/lib/python2.7/socket.py", line 228, in meth
>       return getattr(self._sock,name)(*args)
>   error: [Errno 1073741866] Protocol not available
> 
> Could you please accommodate these architectures?
> 
> Thanks!

Hi,

Without looking too much, this looks like the lack of support for some
socket options websockify is using. I don't really see how I could fix
that. Would you be able to provide a patch?

Also, I maintain websockify for OpenStack. Is there other fields were it
would be useful? If no, then websockify isn't interesting for these
platforms, and we shouldn't care. Your thoughts?

Cheers,

Thomas Goirand (zigo)